NASA-PDS / operations

Tickets for the PDSEN Operations Team
Other
5 stars 1 forks source link

add script to enhance sitemap with ds-view URLs #415

Closed c-suh closed 11 months ago

c-suh commented 11 months ago

🗒️ Summary

Already reviewed and tested:

Latest modifications:

♻️ Related Issues

Resolves #378

sonatype-lift[bot] commented 11 months ago

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. We are extremely grateful and thank you for your support over the years.

đź“– Read about the impacts and timeline

c-suh commented 11 months ago

@nutjob4life I might ask for a re-review in a bit. The script runs manually but errors when run by cron. Will get back to you.

c-suh commented 11 months ago

@nutjob4life never mind! It was rectified by a comment you made in the Slack discussion. However, these sonatype-lift checks are new to me. Did these become a part of our procedures somehow and I completely missed it?

nutjob4life commented 11 months ago

@c-suh yeah, SonaType Lift … it's an extra level of sanity checking that sometimes is more trouble than it's worth—not to mention that it's also going to be retired soon enough. You can decide if you want to make all of its warnings go away.

For example, it says there's no Repo in the git module in from git import Repo—but that's obviously wrong. But it also warns that there's a write(f' </url>\n') that uses an f-string but has no placeholders—which is correct. That should just be write(' </url>\n').

c-suh commented 11 months ago

@nutjob4life got it; thank you - both for the information and your help overall with this task!