NASA-PDS / operations

Tickets for the PDSEN Operations Team
Other
5 stars 1 forks source link

[nssdca-delivery] urn:nasa:pds:juno_jiram #451

Open tinagueth opened 11 months ago

tinagueth commented 11 months ago

Discipline Node Information

NOTE: If you have multiple delivery packages, we strongly encourage you to submit these in batches of 3 to 10 per issue with one ZIP file of the packages and another ZIP file of the validation reports. Please use a descriptive title, such as "Node Mission misc batch #".


Engineering Node Process

See the internal EN process at https://pds-engineering.jpl.nasa.gov/content/nssdca_interface_process

oddes commented 10 months ago

@tinagueth following needs to be corrected and resubmitted.

  1. Version needs to 3.3.
  2. Data Content Validation off
lylehuber commented 10 months ago

3.3 was apparently released on Sept 25. It would have been nice to be notified. But also requiring/demanding it on such a quick turnaround? Let's just say "not cool".

smclaughlin7 commented 10 months ago

@tinagueth This delivery contains two SIPs for the v1.1 of the JUNO JIRAM bundle. I compared the manifest files for both SIPs and determined there are only 6 differences between them:

Product: urn:nasa:pds:juno_jiram:calibration:jir_img_l_responsivity::3.0

Product: urn:nasa:pds:juno_jiram:calibration:jir_img_m_responsivity::3.0

Product: urn:nasa:pds:juno_jiram:calibration:jir_img_tot_responsivity::3.0

The newest SIP, urn:nasa:pds:system_bundle:product_sip_deep_archive:juno_jiram_v1.1_20231101, appears to have been generated on the latest JIRAM bundle v1.1. Since both SIPs are nearly identical, would it be acceptable if EN @oddes only post the newest SIP for the NSSDCA to process? Thanks!

lylehuber commented 10 months ago

Yes that’s fine.

Lyle

smclaughlin7 commented 10 months ago

@lylehuber Thanks, Lyle!

@oddes @c-suh Please post only the newest SIP in this delivery package, SIP LID:

tinagueth commented 10 months ago

@smclaughlin7 @oddes @c-suh I was doing a check-up on all the recent submissions to NSSDCA and when I got to this SIP LID, it states: SIP LIDVID: urn:nasa:pds:system_bundle:product_sip_deep_archive:juno_jiram_v1.1_20231101:: All versions

Not Found:

Remarks: LID(VID) may be incorrect or initial submission was rejected.

will this change based on the above comments? I am trying to keep on top of all the submissions and any issues they have/had for our own documents. Thanks!

c-suh commented 10 months ago

@tinagueth and @lylehuber, apologies for any confusion. We have not processed this submission yet. My colleague, @oddes, mentioned 2 items, the first of which we highly encourage (upgrading to and using the latest version of the Validate tool, currently v3.3.1). We recognize the effort this can take and appreciate your willingness to do so, trusting that the bug fixes and improvements in every release make it worthwhile.

The second item is regarding the Data Content Validation parameter, which must be enabled when validating the products. Please rerun the Validate tool on the newest SIP (i.e., urn:nasa:pds:system_bundle:product_sip_deep_archive:juno_jiram_v1.1_20231101) and do not use the options -D or --skip-content-validation. Once this is done and the validation report is resubmitted (in this same ticket please), we will process and post this for NSSDCA.

Thank you!

jordanpadams commented 9 months ago

@tinagueth can you re-run validate with content validation enabled and upload the report so we can ensure the bundle is valid? (remove --skip-content-validation flag from execution)

lylehuber commented 9 months ago

Validate is currently running. It kept failing because of the out-of-memory issue. I have applied the fix. It should finish around Christmas Day.

jordanpadams commented 9 months ago

@lylehuber copy! Thanks! sorry for the hassle here.

lylehuber commented 9 months ago

No problem, thanks for resolving the NaN issue. I suspect that now that we can do content validation, we might encounter some other issues.

c-suh commented 7 months ago

@lylehuber a quick check on the re-run of validate with content validation enabled. Did it reveal or cause other issues as you anticipated?

lylehuber commented 7 months ago

Yes, it revealed other issues. We should have those cleaned up in the few weeks.

On Feb 2, 2024, at 2:23 PM, Catherine Suh @.***> wrote:

WARNING This email originated external to the NMSU email system. Do not click on links or open attachments unless you are sure the content is safe.

@lylehuberhttps://github.com/lylehuber a quick check on the re-run of validate with content validation enabled. Did it reveal or cause other issues as you anticipated?

— Reply to this email directly, view it on GitHubhttps://github.com/NASA-PDS/operations/issues/451#issuecomment-1924719957, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIX3PMHYVP6KHJTZZYLOJWTYRVKNZAVCNFSM6AAAAAA6277M4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUG4YTSOJVG4. You are receiving this because you were mentioned.Message ID: @.***>

c-suh commented 7 months ago

Okay; thank you for the update and sorry for the trouble!