search

NASA-PDS / pds-api-client

Python library and API for accessing the online PDS Search API. This repository however only contains the utilities used to generate, test, document and demo the actual pds.api-client package. The library itself is only released on pypi (https://pypi.org/project/pds.api-client/) but not here on github
https://nasa-pds.github.io/pds-api-client/
Apache License 2.0
1 stars 2 forks source link

As a client of the client, I'd like to use the new "latest/all" API calls #12

Closed nutjob4life closed 3 years ago

nutjob4life commented 3 years ago

This pull request added features to the registry API that supported getting the latest versus all products when dealing with bundles that contain LID-only as opposed to full LIDVID references.

However the Python API client has not been updated to support these new APIs. It should also be updated.

jordanpadams commented 3 years ago

@nutjob4life it was pushing to this branch instead 🤦 .

just pushed to main. should go to test pypi soon. we can then tag an operational release as soon as you have been able to test.

jordanpadams commented 3 years ago

@nutjob4life actually, I lied. I have no idea how to push this to pypi. @tloubrieu-jpl any ideas how to do this or how we can retrofit this to work with github actions?

tloubrieu-jpl commented 3 years ago

I see how to publish that on pypi following instructions on https://github.com/NASA-PDS/pds-api-client/blob/main/HOW-TO-GENERATE.md

To retrofit it to github action would be a task for later.

nutjob4life commented 3 years ago

@jordanpadams okay, I thought you had to manually pull the swagger.json file somehow.

That's good because the SwaggerHub links (on this page, this page, and this page) all go nowhere.

@tloubrieu-jpl I will follow the instructions and give it a try!

nutjob4life commented 3 years ago

Ooof okay I called it 0.6.2 on testpypi but there are some big API changes: the models module can no longer be implicitly imported by a parental import pds.api_client and the various entity classes in there have been renamed (e.g., Product → Pds4Product), also the bundle_by_lidvid method no longer returns a Product object but a plain dict, member access is by name and not by field, etc.

Upshot is: let's call it 0.7.0 when it goes to the real PyPI.