NASA-PDS / pds-api

PDS web APIs specifications and user's manual
http://nasa-pds.github.io/pds-api
Other
5 stars 3 forks source link

PDS API has an undocumented hit limit of 10000 (even when not asking for data) #261

Closed msbentley closed 1 year ago

msbentley commented 1 year ago

Checked for duplicates

Yes - I've already checked

πŸ› Describe the bug

When testing queries in the API, I often want to explore the number of products matching a given query, even without looking into the data themselves. e.g. I run a query with limit=0. Doing this for broad queries I reach a cap of 10000 in summary/hits.

  1. I can't obviously find this documented limit in the docs,
  2. there are many use cases for counting products which could run into millions.

Given that we already have the limit keyword, I don't understand why "hits" is limited here and would really like to be able to count products into the millions.

πŸ•΅οΈ Expected behavior

I expected summar/hits of the response to give the accurate number of results for my query, and not an artificial limit.

πŸ“œ To Reproduce

r = requests.get(pds_url + 'products',
    params={
        'limit': 0,
        'q': 'pds:Time_Coordinates.pds:start_date_time gt "2001-05-10T00:00:00Z"'})

r.json()['summary']['hits']

This returns 10000

πŸ–₯ Environment Info

No response

πŸ“š Version of Software Used

No response

🩺 Test Data / Additional context

No response

πŸ¦„ Related requirements

πŸ¦„ #xyz

βš™οΈ Engineering Details

No response

jordanpadams commented 1 year ago
alexdunnjpl commented 1 year ago

@jordanpadams regarding docs, does this limit exist in current versions? It shouldn't.

jordanpadams commented 1 year ago

@msbentley as @alexdunnjpl notes, this will be fixed in ~1-3 weeks. If not, please reopen this bug

tloubrieu-jpl commented 1 year ago

We should not have that limit anymore since this ticket https://github.com/NASA-PDS/registry-api/issues/291 is closed. We will investigate that.