search

NASA-PDS / pds-view

PDSView provides support for visualizing PDS3 and PDS4 data products.
https://github.com/NASA-PDS/pds-view/#pdsview
Other
20 stars 7 forks source link

Issue #6: Update Inspect Tool to be PDSView #13

Closed jordanpadams closed 4 years ago

jordanpadams commented 5 years ago

Resolves #6

jordanpadams commented 5 years ago

@galenatjpl @nutjob4life I haven't tried to build with the new naming but I will leave that to you to test it out :-D

also, is there a reason we do this in the build process?

pip install http://pdssbn.astro.umd.edu/ftp/tools/readpds_python/1.0/PDS4_tools-1.0.zip

Is there a reason we don't just build directly from pypi? https://pypi.org/project/pds4-tools/

nutjob4life commented 4 years ago

I'm going to wager the "pip install" from "http://pdssbn.astro.umd.edu" was because PDS4_tools-1.0.zip was not available on PyPI at the time I wrote the instructions. If I'm reading the PyPI logs right, someone added PDS4_tools-1.0.zip to the Cheese Shop at the beginning of April.

nutjob4life commented 4 years ago

Recommending rejecting this PR in favor of https://github.com/NASA-PDS-Incubator/pds-view/pull/18