search

NASA-PDS / pds3-product-tools

Library supporting the design/generation, validation and submission of PDS3 archival products.
https://nasa-pds.github.io/pds3-product-tools/
Apache License 2.0
0 stars 1 forks source link

Add support for pluralized forms of valid unit names are not supported #2

Closed jordanpadams closed 5 years ago

jordanpadams commented 5 years ago

When a label contains pluralized forms of valid unit names, an error is thrown:

ERROR line 12: The unit, "degrees", used for the value of "SOLAR_LATITUDE", was not defined in the dictionary.
ERROR line 13: The unit, "degrees", used for the value of "SOLAR_LONGITUDE", was not defined in the dictionary.
ERROR line 19: The unit, "arcseconds", used for the value of "STAR_DIAMETER", was not defined in the dictionary.

This was a capability that was supported in the previous product tools versions.

jordanpadams commented 5 years ago

Per PDS3 standard, In addition, on page 18-1 of the standards you can find the following:

Both singular and plural unit names, as well as unit symbols, are allowed.

Since the master list does not include pluralized unit names, one can assume that the validation tool should accommodate.

Closing this issue per convo on https://osr.jpl.nasa.gov/jira/projects/PDSEN/issues/PDSEN-267