NASA-PDS / pds4-information-model

The software tools and data necessary for generating the Information Model including PDS4 ontology, data, and information model.
https://nasa-pds.github.io/pds4-information-model/
Other
9 stars 6 forks source link

LDDTool does not support IM version 1J00 #512

Closed c-suh closed 1 year ago

c-suh commented 1 year ago

🐛 Describe the bug

The LDDTool does not support IM Version 1J00

📜 To Reproduce

Steps to reproduce the behavior:

  1. Run the LDDTool (lddtool-14.1.1-bin.zip) with -V 1J00
  2. See error, "Invalid argument list"

🕵️ Expected behavior

The LDDTool finishes without errors.

📚 Version of Software Used

v14.1.1

🩺 Test Data / Additional context

🏞Screenshots

From the second link above in Test Data / Additional context: Screen Shot 2022-10-18 at 9 15 45 AM Screen Shot 2022-10-18 at 9 15 25 AM


🦄 Related requirements

⚙️ Engineering Details

jordanpadams commented 1 year ago

thanks @c-suh

jshughes commented 1 year ago

@jordanpadams , @c-suh This issue results from a constraint on LDDTool's implementation of the -V option. Currently if you want to run LDDTool with the current version of the IM, (e.g. "1J00"), then you do not use the -V option. The -V option is used only for indicating prior versions of the IM. This logic is consistent with the originally proposed option "-A" (Alternate). If this needs to be changed so that the -V option can also indicate the current version of the IM, just let me know.

jordanpadams commented 1 year ago

@jshughes I feel like when we changed this to -V, we changed this functionality to be more consistent with other -V functionality throughout our PDS4 system? Either way, if the -A functionality was the intent, there has been a bug supporting the expected -V.

Moving forward let's treat -V as the version setter for LDDTool. If not given, it defaults to the latest (in this case 1J00), but it can take any available value as input, including the latest version (e.g. 1J00)

jshughes commented 1 year ago

@jordanpadams , @c-suh

Jordan you are correct. The code was set up to be consistent with other -V functionality. My build instructions were not clear about adding the current IM version to -V option list of choices. I have added the current version to the choice list and updated my build instructions.

jordanpadams commented 1 year ago

@jshughes no problem. We will add this to our schedule and make sure we have a task associated with this every build cycle so we don't forget.