search

NASA-PDS / pds4-information-model

The software tools and data necessary for generating the Information Model including PDS4 ontology, data, and information model.
https://nasa-pds.github.io/pds4-information-model/
Other
9 stars 6 forks source link

Issue #650 invalid modification date for ld ds for versions 1 h00 and earlier #653

Closed jshughes closed 1 year ago

jshughes commented 1 year ago

Issue #650 Invalid modification_date for LDDs for versions 1H00 and earlier

Changed the value written for from masterTodaysDateTimeUTCwT to masterTodaysDateUTC, i.e., use the Date and not the DateTime format.

Reason: In release 1.18.0.0 (1I00) the data type for was changed from ASCII_Date_YMD to ASCII_Date_Time_YMD. However for backwards compatibility, the value for that is written to the Product_XML_Schema label must remain of type ASCII_Date_YMD. The data type ASCII_Date_Time_YMD allows for values of type ASCII_Date_YMD.

Resolves #650

⚙️ Test Data and/or Report

During I&T, the values of should validate under all versions of the IM prior to 1.18.0.0 (1I00) .

jordanpadams commented 1 year ago

@jshughes before making any more updates to your local repo, I would make sure your main branch is up to date with the main branch on GitHub. there are lots of weird merges that appear to be happening

jshughes commented 1 year ago

@jordanpadams Before I create any new branch, I always do a pull on main. For this build, I switched from GitHub Desktop to Eclipse Git so there is a new learning curve. @tloubrieu-jpl can we schedule a few minutes to review my process?

jordanpadams commented 1 year ago

@jshughes sounds good. I will also ping the team to see if anyone else can help.

tloubrieu-jpl commented 1 year ago

@jshughes I will schedule something at 2pm, PDT today

tloubrieu-jpl commented 1 year ago

@jshughes Actually I made it 9:30 tomorrow since you were busy on your calendar.