LDDTool is throwing ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing -

[jshughes]

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When LDDTool was run, it threw "ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing".

@jordanpadams this error was addressed by #724 IMTool Refactoring - Deprecate the Java "Deprecated Object Array". Merged #725.

I am not able replicate the error locally using the staged version of the IM #727, merged two weeks ago. But am I am probably missing something.

Not sure that it would help, but could you provide a link to PDS4_KPLO_IngestLDD.xml

🕵️ Expected behavior

I expected no errors.

📜 To Reproduce

1.
2.
3.
...

🖥 Environment Info

- Version of this software [e.g. vX.Y.Z]
- Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
...

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

I&T

TestRail Test ID: T8680960

[jordanpadams]

@jshughes here is the KPLO LDD: https://github.com/pds-data-dictionaries/ldd-kplo/blob/main/src/PDS4_KPLO_IngestLDD.xml

In the future, all IngestLDDs are posted on GitHub here: https://github.com/pds-data-dictionaries/

[jshughes]

@jordanpadams I found two problems and am working on them. Also, I will need to sort through a few things to understand why the LDDTool run in my local Maven build did not catch the problems.

Question: You mentioned adding some smoke tests to the repo. Just wondering how the smoke tests are different from the Maven build test. It is simply a LDDTool run against an LDD.

[jordanpadams]

@jshughes the maven tests always run, but I don’t think we have too many junit tests running? Or at least, our test coverage has not been sufficient to ensure we don’t have breaking changes in our updates. So we decided to introduce some simple smoke tests take the built lddtool package and run it against a couple dLDDs to make sure they don’t break anything. See https://github.com/NASA-PDS/pds4-information-model/pull/735

[miguelp1986]

@jshughes here is the KPLO LDD: https://github.com/pds-data-dictionaries/ldd-kplo/blob/main/src/PDS4_KPLO_IngestLDD.xml

In the future, all IngestLDDs are posted on GitHub here: https://github.com/pds-data-dictionaries/

@jordanpadams confirming that the above file is a test example used to ensure that we do not see the error from this issue.

[jordanpadams]

@miguelp1986 yes that data works. You should also be able to test with just about any of the LDDs from https://github.com/pds-data-dictionaries/