search

NASA-PDS / pds4-information-model

The software tools and data necessary for generating the Information Model including PDS4 ontology, data, and information model.
https://nasa-pds.github.io/pds4-information-model/
Other
9 stars 6 forks source link

LDDTool is not creating valid URL for KPLO #738

Closed jshughes closed 2 months ago

jshughes commented 2 months ago

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

  1. http://www.kari.re.kr/kpdsmission/kplo/v1 - Bad
  2. http://www.kari.re.kr/kpds/mission/kplo/v1 - Good

🕵️ Expected behavior

I expected namespace URL to be valid

📜 To Reproduce

  1. execute LDDTool on KPLO LDD:
lddtool -lpJ ../ldd-kplo/src/PDS4_KPLO_IngestLDD.xml
  1. Open the XSD and notice the namespace URL is http://www.kari.re.kr/kpdsmission/kplo/v1, which should be http://www.kari.re.kr/kpds/mission/kplo/v1

🖥 Environment Info

Linux system

📚 Version of Software Used

latest snapshot as of today

🩺 Test Data / Additional context

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

I&T

TestRail Test ID: T8680961

jordanpadams commented 2 months ago

@jshughes unfortunately this still does not work with a past version of the IM. I tried updating the 1L00 IM config.properties, but it did not work.

> lddtool -lpJ ../ldd-kplo/src/PDS4_KPLO_IngestLDD.xml -V 1L0
> cat ./PDS4_KPLO_1L00_1000.xsd | egrep kpdsmission
    targetNamespace="http://www.kari.re.kr/kpdsmission/kplo/v1"
    xmlns:kplo="http://www.kari.re.kr/kpdsmission/kplo/v1"
jordanpadams commented 2 months ago

NOTE: This works as expected without the -V flag.

jordanpadams commented 2 months ago

Resolved per https://github.com/NASA-PDS/pds4-information-model/commit/60da3721b66e3f6bcf857ec503b1273cc7409cf4

jshughes commented 2 months ago

@jordanpadams Sorry for missing 1L00. Since there is a config.properties file for each version of the IM, I plan to clean up the prior versions. I assume that they will never actually be used but I don't like the clutter.