search

NASA-PDS / pds4-information-model

The software tools and data necessary for generating the Information Model including PDS4 ontology, data, and information model.
https://nasa-pds.github.io/pds4-information-model/
Other
9 stars 6 forks source link

Update to support for open jdk17 #742

Closed jshughes closed 1 month ago

jshughes commented 1 month ago

702 Update to Support for OpenJDK17

🗒️ Summary

The method LDDTool used for setting environment variables is no longer supported in Java17. Determined that there is no need to set the environment variables in the first place. (This was old code originally added by the developer of the Maven script.)

Changes: Three of the four environment variables being set were no longer being used and so were deprecated. The remaining variable, PARENT_DIR is now being set using System.getProperty("user.dir"); This is used to locate the /Data directory, were the config.properties and protege database files are put. The offending code in AbstractGenerationPlugin.java was removed.

⚙️ Test Data and/or Report

The maven build ran successfully.

♻️ Related Issues

Will create new issue to add a command line option to set the relative location of the /Data directory line.

Resolves # 702

jshughes commented 1 month ago

@jordanpadams I just tried to push (actually re-push) my branch with the updates and got the following. Can a branch be re-pushed? Issue742

jordanpadams commented 1 month ago

@jshughes i made some changes to the branch that looks like they were pulled. Can you try doing a git pull on your branch

jshughes commented 1 month ago

@jordanpadams In my local branch, Update_to_Support_for_OpenJDK17Try2, I did a Team -> Pull. A "Problem Occurred" with the following details. (Note: There are not a lot of changes so starting fresh with a new branch would not be a problem.)

Pulling 1 repository Remote origin did not advertise Ref for branch refs/heads/Update_to_Support_for_OpenJDK17Try2. This Ref may not exist in the remote or may be hidden by permission settings. Remote origin did not advertise Ref for branch refs/heads/Update_to_Support_for_OpenJDK17Try2. This Ref may not exist in the remote or may be hidden by permission settings.

jordanpadams commented 1 month ago

@jshughes can you create a new branch off of this one and I can take care of the rest?