search

NASA-PDS / pds4-information-model

The software tools and data necessary for generating the Information Model including PDS4 ontology, data, and information model.
https://nasa-pds.github.io/pds4-information-model/
Other
9 stars 6 forks source link

Update to support for open jdk17 #745

Closed jshughes closed 1 month ago

jshughes commented 1 month ago

Update to support for open jdk17

This is a followup change after deprecating the offending code that set environment variables in LDDTool.AbstractGenerationPlugin.

Updated LDDTool to get the value of "data.home" from the command line. This is the location of the Data directory that contains the config.properties and protege database files.

-Ddata.home=${PARENT_DIR}/Data

Updated LDDTool code to get the value of the system property "data.home"

System.getProperty("data.home")

and use the system property "user.dir" as a fallback

System.getProperty("user.dir")

Resolves #742

jshughes commented 1 month ago

@jordanpadams The message "ERROR SetMasterAttrXMLBaseDataTypeFromDataType" results from a problem addressed in Issue #733, 736. There could be a new error that #733 did not fix, but I am wondering if there isn't a configuration problem. In any case, I am wondering if we could push through the jdk17 changes. I then could pull and create a new branch to continue testing for the "SetMasterAttrXMLBaseDataTypeFromDataType" error.

jordanpadams commented 1 month ago

Merging to main for now. Will keep ticket open until we can verify issue per comment above