search

NASA-PDS / pds4-information-model

The software tools and data necessary for generating the Information Model including PDS4 ontology, data, and information model.
https://nasa-pds.github.io/pds4-information-model/
Other
9 stars 6 forks source link

JDK17 issue re-introduced bug per #733 #746

Closed jordanpadams closed 1 month ago

jordanpadams commented 1 month ago

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When I tried to generate an LDD with the latest code on main, I get the same error as those associated with #733

🕵️ Expected behavior

I expected LDDTool to execute successfully.

📜 To Reproduce

$ test/smoke-tests.sh
...
Test 1: ldd-template
Cloning into 'ldd-repo'...
remote: Enumerating objects: 1833, done.
remote: Counting objects: 100% (860/860), done.
remote: Compressing objects: 100% (406/406), done.
remote: Total 1833 (delta 622), reused 599 (delta 441), pack-reused 973
Receiving objects: 100% (1833/1833), 1.12 MiB | 1.89 MiB/s, done.
Resolving deltas: 100% (1048/1048), done.
debug DMDocument HERE
debug DMDocument -0- sysDataHome:/Users/jpadams/proj/pds/pdsen/workspace/pds4-information-model/lddtool-pkg/lddtool-14.5.0-SNAPSHOT/Data

>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.identifier:0001_NASA_PDS_1.pds.Activity.pds.activity_type
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.valueType:TBD_value_type
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.identifier:0001_NASA_PDS_1.pds.Activity.pds.description
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.valueType:TBD_value_type
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.identifier:0001_NASA_PDS_1.pds.Activity.pds.title
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.valueType:TBD_value_type
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.identifier:0001_NASA_PDS_1.pds.Agent.pds.agent_type
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.valueType:TBD_value_type
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.identifier:0001_NASA_PDS_1.pds.Agent.pds.description
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.valueType:TBD_value_type
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.identifier:0001_NASA_PDS_1.pds.Agent.pds.title
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.valueType:TBD_value_type
>>  ERROR SetMasterAttrXMLBaseDataTypeFromDataType - Data Type is missing - lAttr.identifier:0001_NASA_PDS_1.pds.ChangeLog.pds.%3ANAME

### 🖥 Environment Info

_No response_

### 📚 Version of Software Used

_No response_

### 🩺 Test Data / Additional context

_No response_

### 🦄 Related requirements

_No response_

### ⚙️ Engineering Details

_No response_

I&T

TestRail Test ID: T8827953

miguelp1986 commented 1 week ago

@jordanpadams The test passes, but test/smoke-tests.sh closes out my terminal when the script finishes. I was able to verify that the test passes by redirecting the output to a file.

jordanpadams commented 1 week ago

@miguelp1986 hmmm. I have no idea why it is doing that. The smoke-tests.sh just has exit 0 and exit 1 so not sure why it would close your terminal.

Found this stack overflow where you may have some setting on your Terminal to close when an app exits cleanly. https://superuser.com/questions/1110806/running-a-bash-file-in-a-new-terminal-window-and-close-the-window-when-done