search

NASA-PDS / portal-tasks

PDS Portal tasks repo used to track update requests for the website. Actual code and website are managed in separate private repo
https://pds.nasa.gov
0 stars 0 forks source link

Update DataSet View to display DOI from label if there is no DOI for the product in our database #49

Closed jordanpadams closed 1 year ago

jordanpadams commented 2 years ago

💪 Motivation

Current ds-view uses DOI Search to only search PDS internal database for DOI. This improvement is to search using DOI Search first, and if it does not find anything, try the label metadata.

📖 Additional Details

Here are some examples of bundles with DOIs in their labels, but are not in our database (which is expected): https://pds.nasa.gov/ds-view/pds/viewBundle.jsp?identifier=urn:jaxa:darts:hyb2&version=3.0 https://pds.nasa.gov/ds-view/pds/viewBundle.jsp?identifier=urn:jaxa:darts:hyb2_lidar&version=1.0 https://pds.nasa.gov/ds-view/pds/viewBundle.jsp?identifier=urn:jaxa:darts:hyb2_nirs3&version=1.0 https://pds.nasa.gov/ds-view/pds/viewBundle.jsp?identifier=urn:jaxa:darts:hyb2_tir&version=1.0

🦄 Related requirements

🦄 #7

jordanpadams commented 1 year ago

@c-suh ☝️ does this seem reasonable for this sprint?

c-suh commented 1 year ago

@jordanpadams I believe so. I will need some clarification at the next breakout regarding where/how to find the label metadata. Thank you!

tloubrieu-jpl commented 1 year ago

Catherine need to add back the code which was getting the DOI from the SOLR database as an alternative to the new code which get the DOI from the doi-service API.

c-suh commented 1 year ago

@jordanpadams please review these pages on GAMMA and let me know if it's good to go. If so, I will push these changes to the internal github and deploy on production. Thank you!

jordanpadams commented 1 year ago

@c-suh looks good to go. 💯

c-suh commented 1 year ago

Done and done!