NASA-PDS / portal-tasks

PDS Portal tasks repo used to track update requests for the website. Actual code and website are managed in separate private repo
https://pds.nasa.gov
0 stars 0 forks source link

Links returning 404 #68

Closed anilnatha closed 1 year ago

anilnatha commented 1 year ago

Checked for duplicates

Yes - I've already checked

πŸ› Describe the bug

After running a crawl of the pds.nasa.gov for sitemap generation purposes, the results of this crawl showed that the following URLs that were specified somewhere on the site are returning an HTTP status of 404 which can negatively affect our SEO:

πŸ•΅οΈ Expected behavior

The pages should not return a 404.

πŸ“œ To Reproduce

Simply visit any of the links mentioned in this post.

πŸ–₯ Environment Info

No response

πŸ“š Version of Software Used

No response

🩺 Test Data / Additional context

No response

πŸ¦„ Related requirements

No response

βš™οΈ Engineering Details

No response

jordanpadams commented 1 year ago

@c-suh are these couple portal task tickets something @acyu-jpl could help with?

c-suh commented 1 year ago

@jordanpadams I believe I have addressed the check-listed items and have pulled this onto the machines. Does Anil need to regenerate a sitemap? Let me know any next steps; thank you!

jordanpadams commented 1 year ago

@c-suh I think we are good to close

tloubrieu-jpl commented 1 year ago

@c-suh All the links return 404 again... I am reopening this ticket

c-suh commented 1 year ago

@tloubrieu-jpl most of the links are not valid anymore. I assumed they were found by the program creating the sitemap and addressed these in the website code. Since these were faulty URLs, in commented-out code, or in extremely old and rarely used pages, I did not see a need to set up redirects, but would you like me to do so? Does verifying this task completion involve a regeneration of the sitemap?

tloubrieu-jpl commented 1 year ago

Hi @c-suh , so the fix was to remove the URL from where they were used ?

c-suh commented 1 year ago

@tloubrieu-jpl yes, it was mostly removing URLs. I updated the link for the phonebook and a few others I found which were not listed above, e.g. https://pds.nasa.gov/tools/ddlookup/data_dictionary_lookup.cfm --> https://pds.nasa.gov/tools/dd-search/.

tloubrieu-jpl commented 1 year ago

Hi @gxtchen , I believe the best would be to test this ticket by having updated results for the link checker used by PDS Engineering Node. @c-suh found this page about the PDS Link checker. Could you investigate and add a non regression test checking for absence of broken links in the web site. Thanks.

tloubrieu-jpl commented 1 year ago

Hi @anilnatha , would you be able to propose us a good tool to check links on a regular basis for the web site ?