URL Encoding errors from Subscription Service pages

NASA-PDS / portal-tasks

PDS Portal tasks repo used to track update requests for the website. Actual code and website are managed in separate private repo

https://pds.nasa.gov

0 stars 0 forks source link

URL Encoding errors from Subscription Service pages #8

Closed jordanpadams closed 1 year ago

jordanpadams commented 2 years ago

🐛 Describe the bug

Per Markup Validation, looks like the pages being generated by the subscription service are encoding URLs incorrectly. Browsers are being more forgiving, but we should look into fixing this.

https://validator.w3.org/check?uri=https%3A%2F%2Fpds.nasa.gov%2Fdatasearch%2Fsubscription-service%2FSS-20220104.shtml&charset=%28detect+automatically%29&doctype=Inline&group=0&ss=1&verbose=1#line-208

🕵️ Expected behavior

📚 Version of Software Used

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

anilnatha commented 2 years ago

The screenshot I shared was a test scan of a single page in the subscription service, if a copy of the full system scan report is needed, let me know.

viviant100 commented 2 years ago

@acyu-jpl see above

acyu commented 2 years ago

@viviant100 I close to deploy the python script that will go through shtml file, parse the href link and update & to proper encoded value. I will run the script on pds-gamma soon, once I have verify there is no issue with the output.

anilnatha commented 2 years ago

@acyu I can run a test using the software that reported the issue if you would like additional verification of your fixes. Just let me know.

acyu commented 2 years ago

Hi, @anilnatha, I ran the script on pds-gamma.jpl.nasa.gov/datasearch/subscription-service, quick spot check such on https://pds-gamma.jpl.nasa.gov/datasearch/subscription-service/PDS-Subscription-Service-01-Feb-07.shtml and https://pds-gamma.jpl.nasa.gov/datasearch/subscription-service/PDS-Subscription-Service-28-Jul-04.shtml show & has been properly converted.

Can you run the same test on pds-gamma to verify the fix?

anilnatha commented 2 years ago

Hi @acyu , I ran the test and it appears that the issue has been resolved regarding the links in the body of the page!

The scan found one more un-encoded URL in the head tag of the document for both of the URLs shared. Here is what was found on the first URL, that also applies to the second:

acyu commented 2 years ago

Hi, @anilnatha I found the & in the include file, which is easy to update. Please run the test again when you are available. Thank you

acyu commented 2 years ago

file changes had been committed to push to prod1 & prod2

viviant100 commented 2 years ago

@anilnatha Just to confirm the updates resolve your issue before we close the ticket.

jordanpadams commented 1 year ago

I think we wanted confirmation from @anilnatha on this, but let's close this out and can open a new ticket if it sneaks back up