Updated header components

NASA-PDS / portal-wp-tasks

PDS Web Design System

https://github.com/NASA-PDS/pds-wds

Apache License 2.0

0 stars 0 forks source link

Updated header components #55

Closed anilnatha closed 4 months ago

anilnatha commented 1 year ago

The title and navbar components need additional polish and work.

[x] Migration of component into wds-react package
[ ] Further style improvements to improve alignment with Figma design
[x] Implement menu systems
[x] Update Iconography

tloubrieu-jpl commented 10 months ago

@anilnatha is making progress on this ticket.

tloubrieu-jpl commented 9 months ago

@eddiesarevalo is migrating the component to wds-react repository. The tests are made a second application which calls this component.

eddiesarevalo commented 9 months ago

Breaking out this ticket into an epic.

nutjob4life commented 8 months ago

Eddie's branching out with Anil to discuss a bigger issue: styles from Web Design System into our own components in a maintainable way. Current way is too messy. Will become more difficult down the line. Researched CSS modules as a possible solution—but too confusing. Good solution: use plain CSS and material class names. Will feedback with Anil. Mike also asked if we'll need to support themes. If Anil's good, will update header styles. Will switch rest of component library on agreed-upon method.

eddiesarevalo commented 7 months ago

@anilnatha Pull request for wds-react https://github.com/NASA-PDS/wds-react/pull/24 Pull request for wds https://github.com/NASA-PDS/wds/pull/19