search

NASA-PDS / registry-api

Web API service for the PDS Registry, providing the implementation of the PDS Search API (https://github.com/nasa-pds/pds-api) for the PDS Registry.
https://nasa-pds.github.io/pds-api
Apache License 2.0
2 stars 5 forks source link

Remove or fix UnsupportedSearchProperty #528

Open alexdunnjpl opened 3 weeks ago

alexdunnjpl commented 3 weeks ago

💡 Description

A custom exception UnsupportedSearchProperty is defined, and caught/handled all over the codebase, but is never thrown. It relates to the conversion between / and ., which cannot fail.

@jordanpadams @tloubrieu-jpl is it intended that properties be validated (if so, what validation rules?) or can this exception be stripped out of the codebase?

⚔️ Parent Epic / Related Tickets

No response

alexdunnjpl commented 3 weeks ago

As part of this ticket, remove these utility functions and replace their usages with PdsProperty equivalents.

jordanpadams commented 3 weeks ago

@alexdunnjpl I think eventually from an end user perspective it would be helpful to catch an incorrect search property from a typo or something like that, but we don't have that as a requirement right now. Since it is not being used properly at the moment, we can remove and add back later.