search

NASA-PDS / registry-api

Web API service for the PDS Registry, providing the implementation of the PDS Search API (https://github.com/nasa-pds/pds-api) for the PDS Registry.
https://nasa-pds.github.io/pds-api
Apache License 2.0
2 stars 5 forks source link

/properties endpoint #530

Closed alexdunnjpl closed 1 month ago

alexdunnjpl commented 1 month ago

🗒️ Summary

Re-implements /products endpoint. Implements a helper class PdsProperty, which should gradually replace the associated utility class (and be extended, if validation is determined to be required.

⚙️ Test Data and/or Report

Existing test PDS/registry-api#277 /properties endpoint (testrail C2488844) passes

re-implements #277 #322 closes #506

tloubrieu-jpl commented 1 month ago

However @alexdunnjpl , I am now having an error with the integration test, for example:

 Unable to parse q (product_class EQ "Product_Bundle")error message is org.antlr.v4.runtime.misc.ParseCancellationException
2024-08-22T11:35:36.904-04:00  INFO 78031 --- [nio-8081-exec-6] g.n.p.a.r.m.e.RegistryApiException       : 8a163485-e6c9-4a28-b449-660674ee58b4 UnparsableQParamException: Unable to parse the q parameter:q string value:(product_class EQ "Product_Bundle") Error message null
2024-08-22T11:35:36.904-04:00 DEBUG 78031 --- [nio-8081-exec-6] .m.m.a.ExceptionHandlerExceptionResolver : Using @ExceptionHandler gov.nasa.pds.api.registry.controllers.RegistryApiResponseEntityExceptionHandler#unparsableQParam(UnparsableQParamException, WebRequest)
2024-08-22T11:35:36.904-04:00 DEBUG 78031 --- [nio-8081-exec-6] o.s.w.s.m.m.a.HttpEntityMethodProcessor  : Using 'application/json', given [application/json] and supported [text/plain, */*, application/json]

That might be something wrong on my side, I will investigate that later. I just wanted to give you a heads up.

tloubrieu-jpl commented 1 month ago

@alexdunnjpl , weirdly you don't have the latest version of lexer/src/main/antlr4/gov/nasa/pds/api/registry/lexer/Search.g4 in this branch which causes some tests to fail. Do you know why ?

alexdunnjpl commented 1 month ago

@alexdunnjpl , weirdly you don't have the latest version of lexer/src/main/antlr4/gov/nasa/pds/api/registry/lexer/Search.g4 in this branch which causes some tests to fail. Do you know why ?

@tloubrieu-jpl that's because (presumably) you're running the tests on this branch rather than the result of merging this branch into develop, and this branch doesn't have the relevant commit(s).

I've rebased on develop, so that should be sorted now.