search

NASA-PDS / registry-mgr

Standalone Registry Manager application responsible for managing the PDS Registry (https://github.com/NASA-PDS/registry) schemas and indexes.
https://nasa-pds.github.io/registry
Other
0 stars 2 forks source link

Improve error message for corrupted registry_docs.json #43

Closed pds-ops closed 2 years ago

pds-ops commented 2 years ago

🐛 Describe the bug

Several users have noted a [ERROR] null coming from a registry manager execution with an invalid JSON. We should catch this error and report it more clearly to the user.

📜 To Reproduce

🕵️ Expected behavior

More clear error message that the JSON is invalid, most likely due to a file system issue. Either direct the user to documentation for debugging (if it exists?), or just not they should re-run harvest.

📚 Version of Software Used

🩺 Test Data / Additional context

Take any valid registry_docs.json, make it invalid JSON, and try to ingest with registry manager

tdddblog commented 2 years ago

The latest version of Harvest loads data directly into Elasticsearch. Temporary JSON data files are not generated anymore. See https://github.com/NASA-PDS/harvest/pull/83

"load-data" command was removed from Registry manager. See https://github.com/NASA-PDS/registry-mgr/pull/45

jordanpadams commented 2 years ago

per comment above, this has been closed.