Missing snapshot tag cleanup prior to new unstable release

[jordanpadams]

Describe the bug The SNAPSHOT releases are being recreated for each unstable CI/CD run, but the tags are not being cleaned up. This causes the tags and release assets to get out of sync.

To Reproduce See latest validate snapshot.

It says @pdsen-ci pdsen-ci released this 6 minutes ago but then follows with 7 commits to master since this release indicating a new tag was not created with the new release

Proposed Fixes

Java:

    - name: Clean previous dev/snapshot tags
      run: |
        git fetch --prune --unshallow --tags
        git tag -l | grep 'SNAPSHOT' | xargs -t -I arg sh -c 'git tag -d arg;git push --delete origin arg;'

Python (haven't tested this with Python, but assuming it has the same issue?):

    - name: Clean previous dev/snapshot tags
      run: |
        git fetch --prune --unshallow --tags
        git tag -l | grep 'dev' | xargs -t -I arg sh -c 'git tag -d arg;git push --delete origin arg;'

[nutjob4life]

Unfortunately, when I tried git fetch --prune --unshallow --tags I get an error:

fatal: --unshallow on a complete repository does not make sense

I'm not sure what this means.

See:

• https://github.com/NASA-PDS/roundup-action/blob/master/src/pds/roundup/_maven.py#L164
• https://github.com/NASA-PDS/roundup-action/blob/master/src/pds/roundup/_python.py#L97

[nutjob4life]

Further research: in my test environment, I do plain git clone during testing while the checkout action only clones the ref that triggered the workflow.

Pressing on!

[nutjob4life]

Ah I think I found the problem.

In Python I'm filtering for *dev* but in Maven I copied the same logic over when I should be looking for *SNAPSHOT*

(Also FYI, no need to pipe git tag -l into grep since it has filtering capability built-in.)

[jordanpadams]

@nutjob4life this unfortunately doesn't look to be fixed. see latest build of validate.

[jordanpadams]

@nutjob4life unfortunately, it still doesn't look like this has been fixed?

https://github.com/NASA-PDS/validate/releases/tag/1.25.0-SNAPSHOT

[tloubrieu-jpl]

@nutjob4life needs to update the docker image with git-lfs

[nutjob4life]

Here's where I think the issue is:

[nutjob4life]

Okay, updated the base image with git-lfs and re-ran the action on validate. Here's a screenshot of the step now:

Does that look like it fixed it @jordanpadams?

[jordanpadams]

🎉 looks good @nutjob4life. let me see what else I can break...