search

NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

Roundup pushes version update prior to completion of execution #124

Closed jordanpadams closed 8 months ago

jordanpadams commented 8 months ago

Checked for duplicates

No - I haven't checked

🐛 Describe the bug

A tag of a release that failed on upload to Maven central, the version increment was still committed to main.

🕵️ Expected behavior

I expected the push to main would be one of the last steps of the process. The version increment needs to happen early on, but the commit of the version update is not needed until the last step after everything was successful.

📜 To Reproduce

Try to build a java repo and see it fail.

Exhibit A: https://github.com/NASA-PDS/transform/actions/runs/6630418254 With push even with the failure: https://github.com/NASA-PDS/transform/actions/runs/6631314379

🖥 Environment Info

No response

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

nutjob4life commented 8 months ago

Note that this is still in progress and pull request № 126 referenced above is a pre-requisite to a forthcoming pull request.

gxtchen commented 2 months ago

@jordanpadams @nutjob4life Can I test this in my testing environment?

jordanpadams commented 2 months ago

@gxtchen you can skip this