NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

Splits version bumping step into two separate steps #127

Closed nutjob4life closed 8 months ago

nutjob4life commented 8 months ago

🗒️ Summary

Merge this and you'll alter the way a roundup does an assembly. Previously, it had a "version bumping" step that would increase the version number in the system and commit it, then do the rest of the assembly.

However, as #124 noted, if a later step failed, that version number was already committed.

Merge this and "version bumping" gets split into two separate steps:

⚙️ Test Data and/or Report

You can see this work especially in Maven projects which are prone to Sonatype OSSRH central artifactory failures. Note, for example, the runs in the Maven sandbox repository (newer actions appear closer to the top, ignore the commit messages—look at the "branch" column):

Thankfully OSSRH is so flaky this was easy to test. For completion, I also tested it in the sandbox Python repository. There, you can see release/3.2.0 which was successful then triggered a commit of the VERSION.txt to main.

♻️ Related Issues

nutjob4life commented 8 months ago

👉 Note: to take effect, the stable tag for roundup-action will need to be moved to this merge.

nutjob4life commented 8 months ago

Moved stable