search

NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

python stable does not work on pds-doi-service #18

Closed tloubrieu-jpl closed 3 years ago

tloubrieu-jpl commented 3 years ago

Describe the bug The error can be found in https://github.com/NASA-PDS/pds-doi-service/runs/1444380603?check_suite_focus=true

To Reproduce Create a tag on pds-doi-service

nutjob4life commented 3 years ago

I see the error message in the log file referenced above, but I don't think it's related to the Roundup Action. (This issue is labeled as a bug in the Roundup Action, but it seems to be environmental, perhaps similar to how /bin/ls /non/existent also gives an error message, but isn't a bug in /bin/ls? 🤷‍♀️)

Regardless, I'm unable to reproduce using the instructions given above. Here's what I did:

  1. git clone git@github.com:NASA-PDS/pds-doi-service.git
  2. cd pds-doi-service
  3. git tag -a -m 'Roundup testing; ignore' v9.8.7
  4. git push origin v9.8.7

This resulted in a successful roundup; see: https://github.com/NASA-PDS/pds-doi-service/runs/1475377400

Am I missing something? Please let me know. If this is truly a bug in the Roundup, I'd like to stamp it out 🤨

Screen Shot 2020-11-30 at 12 37 08 PM

nutjob4life commented 3 years ago

For purposes of milestone PDS.05 due 2020-12-02 (today) I recommend closing this with the resolution "unable to reproduce". Feel free to re-open in another sprint should it appear again.

tloubrieu-jpl commented 3 years ago

I was still reproducing the error but was able to overcome it by adding fetch-depth: 0 option to the checkout action. For example:

steps:

            name: 💳 Checkout
            uses: actions/checkout@v2
            with:
                lfs: true
                fetch-depth: 0

This might also have impacts, so I don't recommend to apply it always yet.