NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

roundup commits but doesn't push updated Changelog or Requirements to Github #29

Closed jordanpadams closed 3 years ago

jordanpadams commented 3 years ago

Describe the bug Not sure if this is an update for roundup or pds-github-util but current roundup RequirementsStep and ChangeLogStep commit to Github but they never get pushed.

github_changelog_generator --user NASA-PDS --project $REPO_NAME  \
                           --output CHANGELOG.md --token $GITHUB_TOKEN \
                           --future-release v$NEW_VERSION \
                           --configure-sections '{"requirements":{"prefix":"**Requirements:**","labels":["requirement"]},"improvements":{"prefix":"**Improvements:**","labels":["enhancement"]},"defects":{"prefix":"**Defects:**","labels":["bug"]}}' \
                           --no-pull-requests --issues-label '**Other closed issues:**' \
                           --exclude-labels "wontfix", "duplicate", "invalid","theme" \
                           --issue-line-labels 's.critical,s.high,s.low,s.medium'
tloubrieu-jpl commented 3 years ago

I made the change in the roundup so that CHANGELOG and requirements are pushed.

That works on repo https://github.com/NASA-PDS/pds-registry-mgr-elastic for stable release.

Since the files are pushed on the master branch, this requires some specific parameters at checkout in the github action see https://github.com/NASA-PDS/pds-registry-mgr-elastic/blob/master/.github/workflows/stable-cicd.yaml

tloubrieu-jpl commented 3 years ago

This needs to be re-opened since the current solution create the changelog after the tag.