search

NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

Resolve #23 with way to override Maven phases/goals #30

Closed nutjob4life closed 3 years ago

nutjob4life commented 3 years ago

📜 Summary

Fix #23 so that you can override the phases and/or goals the Roundup uses when invoking Maven at various points.

🩺 Test Data and/or Report

There's no way to test this without a massive test harness (which would include: GitHub Actions ecosystem, actions runners, virtual machines, public key infrastructure, OSSRH stub, PyPI stub, etc.).

🧩 Related Issues

jordanpadams commented 3 years ago

@tloubrieu-jpl give this a test drive per whichever repo you were trying to use this and let's see how it goes

tloubrieu-jpl commented 3 years ago

@nutjob4life @jordanpadams I have bug since the update apparently.

CRITICAL:pds.roundup.util:📚 Stderr = «» Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/pds.roundup-0.0.0-py3.8.egg/pds/roundup/util.py", line 45, in invoke File "/usr/local/lib/python3.8/subprocess.py", line 512, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['mvn', '']' returned non-zero exit status 1.

On action https://github.com/NASA-PDS/pds-registry-app/runs/1645833559?check_suite_focus=true

I tried to explicitly have the maven goals as specified in the roundup readme but that did not help.

nutjob4life commented 3 years ago

@tloubrieu-jpl could I see your workflow's yaml file?

Or are you saying this is happening without modification to your workflow's yaml file? 🤨

tloubrieu-jpl commented 3 years ago

Hi @nutjob4life I retested with this workflow https://github.com/NASA-PDS/pds-registry-app/blob/master/.github/workflows/unstable-cicd.yaml

and had the same error as yesterday.

nutjob4life commented 3 years ago

Thanks @tloubrieu-jpl; I'm going to re-open #23