search

NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

roundup action unstable releases appear to be unstable #52

Closed jordanpadams closed 2 years ago

jordanpadams commented 2 years ago

🐛 Describe the bug

  1. unstable releases are being tagged as stable releases
  2. past unstable releases are not being cleaned up from the repo

📜 To Reproduce

Steps to reproduce the behavior:

  1. See https://github.com/NASA-PDS/pds-template-repo-python/releases/latest points to a dev release generated by this unstable CICD action
  2. See https://github.com/NASA-PDS/pds-template-repo-python/releases for all the past dev releases included (oops! i cleaned these up... but trust me. it happens)

🕵️ Expected behavior

  1. Unstable releases should be tagged as Pre-Release and, for python, maybe renamed to something cleaner (is there something standard others use)?
  2. Cleanup of old dev releases - Up for discussion. I see both sides of this. Having all past tagged versions is great for complete transparency. maybe we only cleanup at each stable release (or if the tag already exists)?
MJJoyce commented 2 years ago

unstable releases look like they're being properly marked as SNAPSHOT at the moment: https://github.com/NASA-PDS/pds-github-util/releases

That was addressed here and in the linked ticket.

Currently it looks like the snapshot releases are being removed as we expect but tags are not. See here: Screen Shot 2021-09-16 at 14 06 23

I imagine we'll want those stripped out.

MJJoyce commented 2 years ago

Note, after #62 / #63 are merged I think (please don't jinx it, please don't jinx it) that this can be marked as resolved.

nutjob4life commented 2 years ago

Issue #62 is closed and #63 is merged so closing 🤞