NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

Roundup still using nasa-pds-engineering-node pds-github-util #78

Closed jordanpadams closed 2 years ago

jordanpadams commented 2 years ago

🐛 Describe the bug

See https://github.com/NASA-PDS/pds-registry-common/runs/4769193173?check_suite_focus=true#step:2:67

Screen Shot 2022-01-10 at 4 33 08 PM

It looks like we are trying to clone pds-github-util instead of install with pip and it is failing in all repos with error about deprecated git commands

nutjob4life commented 2 years ago

There are actually three things happening here:

  1. We're not git cloneing pds-github-util; we are indeed pip installing it, but using this command:
    pip install 'git+git://github.com/NASA-PDS/pds-github-util@stable#egg=pds_github_util'
  2. However, effective 2022-01-11, the git:// protocol became unsupported when used unencrypted but even when completely internal to GitHub.
  3. The roundup-action@stable is one commit behind roundup-action@main and contains a reference to nasa-pds-engineering-node (the sandbox).

I'll tackle these momentarily—but first: ☕️😅

nutjob4life commented 2 years ago

Since this is absolutely critical and is what I hope will be a one-line fix, I'm going to exercise "executive privilege" and commit this directly to main & stable.

The fix is to change this:

pip install 'git+git://github.com/NASA-PDS/pds-github-util@stable#egg=pds_github_util'

to this:

pip install 'git+https://github.com/NASA-PDS/pds-github-util@stable#egg=pds_github_util'
jordanpadams commented 2 years ago

Looks to have worked. Thanks @nutjob4life !

nutjob4life commented 2 years ago

awkward-dance-awkward