NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

roundup versioning not working properly on nested maven repositories #82

Closed tloubrieu-jpl closed 2 years ago

tloubrieu-jpl commented 2 years ago

๐Ÿ› Describe the bug

per https://github.com/NASA-PDS/pds4-information-model/runs/6067059849?check_suite_focus=true#step:5:209, this error occurs when the top-level POM version number is changed, but the lower level POM versions are not updated.

๐Ÿ“œ To Reproduce

Steps to reproduce the behavior:

  1. Fork / clone pds4-information-model repo into sandbox
  2. git checkout -b release/14.0.1
    git push origin release/14.0.1
  3. see error above

As a workaround, after deleting the original branch, I manually versioned the repo and it worked:

git checkout -b release/14.0.1
mvn versions:set -DnewVersion=14.0.1
git add pom.xml
git add */pom.xml
git commit -m "Prep for v14.0.1 release"
git push origin release/14.0.1

And it worked as expected. However, per this commit roundup only versioned the top-level POM when transitioning back to SNAPSHOT, so the unstable build is now failing.

Other info:

๐Ÿ•ต๏ธ Expected behavior

Versions properly

๐Ÿ“š Version of Software Used

๐Ÿฉบ Test Data / Additional context

๐ŸžScreenshots

๐Ÿ–ฅ System Info


๐Ÿฆ„ Related requirements

โš™๏ธ Engineering Details

nutjob4life commented 2 years ago

@jordanpadams thanks for the incredibly thorough report. Tells me precisely what to fix.