Open nutjob4life opened 1 year ago
@nutjob4life how would you propose we fix this? should we update the commit commands for python?
@jordanpadams as mentioned in the bug report, I'd use the template method design pattern. (I should've used it in the first place.)
"Template method" lets a superclass dictate the structure of an algorithm while subclasses can provide context-specific needs. The git
commands would be in the superclass while the Maven-specific or Python-specific parts would be in each subclass.
@nutjob4life copy. will add this to the icebox for now. I think this is a good idea, but as you mentioned elsewhere, if we use Harness for some of this, it may all change.
🐛 Describe the bug
While implementing #90, I discovered that the
git
operations performed by the Roundup Action in Maven and Python repositories have drifted apart.For example, the "version bump" step for Python does
while the Maven "version bump" step does
The "GitHub release" step similarly differs in its handling, as does the "repo cleanup" step.
The Roundup Action uses the abstract factory design pattern to create
Step
objects appropriate to the Roundup. But it should also use the template method design pattern so that thegit
steps are identical between repository instances. For example, it could look like this (demonstrating two of the steps):🕵️ Expected behavior
git
operations should identical between Maven and Python repositories.📚 Version of Software Used
Current
stable
.🩺 Test Data / Additional context
🦄 Related requirements
⚙️ Engineering Details