NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

Don't treat OSSRH deployment errors as "soft" #94

Closed nutjob4life closed 1 year ago

nutjob4life commented 1 year ago

When Roundup does mvn deploy with the release profile in the ArtifactPublicationStep, we treat errors here as "soft"; that is, we can ignore them and move on.

This made sense in the past when we were re-running Roundups for a single release and wanted to get past OSSRH publication. However, the mvn deploy does a ton of different things and now site (javadoc) generation is failing in the registry-api.

We should fail on this, of course! But really, we shouldn't be re-running Roundups anyway. So the easiest solution is just treat mvn deploy failures as "hard" errors"