search

NASA-PDS / roundup-action

Do a "roundup", a/k/a PDS-style continuous integration and delivery
Apache License 2.0
1 stars 4 forks source link

Roundup failing on unstable build #96

Closed jordanpadams closed 1 year ago

jordanpadams commented 1 year ago

🐛 Describe the bug

Unstable build failing

📜 To Reproduce

Steps to reproduce the behavior:

  1. Go to Validate repo (or I imagine a lot of our repos)
  2. Try to push to main to trigger unstable roundup

🕵️ Expected behavior

Builds successfully

📚 Version of Software Used

stable

🩺 Test Data / Additional context

https://github.com/NASA-PDS/validate/actions/runs/3200657350/jobs/5227818080

🦄 Related requirements

⚙️ Engineering Details

It looks like we are trying to pull the release/* tags here: https://github.com/NASA-PDS/roundup-action/blob/fa2d51156697b734ea1e477a03d25c16914a39c2/src/pds/roundup/step.py#L90 . And git describe fails if none exist.

That being said, should we really be looking for the release/* tags? We remove those after we create an actual tag, so we should really get the latest tag number and then increment that accordingly, no?

nutjob4life commented 1 year ago

@jordanpadams it looks like the old behavior for changelog generation was to do git branch --show-current and use its output for the changelog's future release number (see the diff). I can bring that back.

Do we want changelog generation on unstable releases too, though? Maybe the better fix is to skip changelogs on unstables? What do you think?

jordanpadams commented 1 year ago

@nutjob4life I think we should still do changelog for unstable so folks can see what has been updated in the current snapshot. That being said, how will you then know its a snapshot version of you are on main?

nutjob4life commented 1 year ago

Basically the same way as before, but detecting if the git describe fails