search

NASA-PDS / s3-browser-cloudfront

Web view for files in S3 buckets
Other
1 stars 0 forks source link

As a data user, I want to view ODR S3 bucket with S3 browser app #22

Closed tloubrieu-jpl closed 6 months ago

tloubrieu-jpl commented 8 months ago

Checked for duplicates

No - I haven't checked

🧑‍🔬 User Persona(s)

Data engineer

💪 Motivation

...so that I can expose my bucket to my user who would like to browse and download the datasets.

📖 Additional Details

No response

Acceptance Criteria

Given ODR s3 bucket (for example https://aws.amazon.com/marketplace/pp/prodview-zetjfybagtrl2?sr=0-8&ref_=beagle&applicationId=AWSMPContessa#resources) When I perform a deployment of s3-browser with proper configuration Then I expect to have web pages enabling users to browse the file or the bucket and download them through an HTTP link to S3 without going through cloudfront or any proxy server.

⚙️ Engineering Details

No response

tloubrieu-jpl commented 7 months ago

@eddiesarevalo uses the USGS code and is able to show the ODR bucket and another S3 bucket.

The style remains to be worked on, so to add what we had in the previous demo.

And there are CORS issues to resolve. This is the priority for now.

eddiesarevalo commented 7 months ago

Added in https://github.com/NASA-PDS/s3-browser-cloudfront/commit/09abccd28ce411289988e8b6667a8cbf0f184178

tloubrieu-jpl commented 7 months ago

The style is back, we will discuss the CORS issues during the breakout.

tloubrieu-jpl commented 7 months ago

The bucket got allow only SSL which made the portal get 403 errors. @eddiesarevalo removed it so that it works again.

jordanpadams commented 7 months ago

status: SSL policy on bucket was tested successfully. 🎉

fixed minor bug with slashes

jordanpadams commented 7 months ago
jordanpadams commented 6 months ago

@eddiesarevalo do we have a PR for this and #25 ready?

eddiesarevalo commented 6 months ago

@jordanpadams The pull request is here: https://github.com/NASA-PDS/s3-browser-cloudfront/pull/30 This merges to the develop branch which is up to date with main. We can then merge to main after the demo, or right away if its ready.

viviant100 commented 6 months ago
  • [x] @viviant100 to SSL policy from pds-infra-temp to ODR bucket and confirm with Eddie to test

Done.

jordanpadams commented 6 months ago

resolved by https://github.com/NASA-PDS/s3-browser-cloudfront/pull/30

jordanpadams commented 6 months ago

and task above by @viviant100

jordanpadams commented 2 weeks ago

Skipping I&T. Tested via inspection during website deployment