search

NASA-PDS / s3-browser-cloudfront

Web view for files in S3 buckets
Other
1 stars 0 forks source link

Updates to view data from multiple S3 buckets #30

Closed eddiesarevalo closed 2 months ago

eddiesarevalo commented 2 months ago

🗒️ Summary

Multiple buckets can now be viewed at once.

⚙️ Test Data and/or Report

Set up normally as in the readme if you have access to MCP and AWS.

A faster way is to switch to this branch. Then run npm run build, then run "python -m SimpleHTTPServer 9001" on the root directory of the project. Open a browser to localhost:9001 then verify everything runs. (You might need a CORS extension for your browser to get around CORS blocks).

♻️ Related Issues

nutjob4life commented 2 months ago

python -m SimpleHTTPServer 9001 only works in Python 2, which reached end-of-life on January 1st, 2020!

The modern equivalent would be python3 -m http.server

jordanpadams commented 2 months ago

@eddiesarevalo is this build expected to fail on Node.js 16.x and 18.x?

eddiesarevalo commented 2 months ago

@jordanpadams it works on node v16 and v18. It has an nvmrc file though so that nvm sets it to v18

anilnatha commented 2 months ago

@jordanpadams The Node.js tests breaking are something we need to address in other repos too. For this repo, I think we should remove the Node.js 14.x and 16.x tests as they don't provide any value. Both 14 and 16 versions are no longer supported by Node.js

jordanpadams commented 2 months ago

@anilnatha @eddiesarevalo copy. will remove 14 and 16, for v18, how should we update your branch build so we build successfully?

    steps:
    - uses: actions/checkout@v4
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v4
      with:
        node-version: ${{ matrix.node-version }}
        cache: 'npm'
        token: ${{secrets.ADMIN_GITHUB_TOKEN || github.token}}
    - run: npm ci
    - run: npm run build --if-present
    - run: npm test

It looks like it is failing on the npm test because there is no test file.