search

NASA-PDS / s3-browser-cloudfront

Web view for files in S3 buckets
Other
1 stars 0 forks source link

Develop to main #32

Closed jordanpadams closed 2 months ago

nutjob4life commented 2 months ago

Good morning @jordanpadams! I was going through my morning notifications and was about to review this but I see it's merged with no reviews and the description is empty. Was this an emergency of some sort?

jordanpadams commented 2 months ago

@nutjob4life I was trying to resolve some old dependabot alerts that were on main. I am hoping the dependabot alerts will now work as expected with develop as the target branch.

The changes merged should have just been the changes from this PR or maybe a couple others that have already been merged into develop. In the future, when we merge develop into main we should discuss whether or not a full PR review is really needed considering all the changes merged to develop should have been reviewed once already.

The develop to main merge may just be a go/no-go for prepping for release and/or hopefully continuous deployment to a staging environment.

nutjob4life commented 2 months ago

@jordanpadams cool, thanks for clearing that up! I'm all for streamlining so I appreciate the explanation.