NASA-PDS / software-issues-repo

Issue tracking repository as a centralized entry point for general PDS software bugs and feature requests.
Apache License 2.0
0 stars 0 forks source link

[ds-view] Add link to DOI page on each landing page JSP #5

Closed jordanpadams closed 2 years ago

jordanpadams commented 3 years ago

Is your feature request related to a problem? Please describe. We need to add a Data Object Identifier (DOI) row to each of the landing pages.

Right now, to stage this change, let's just link to this TBD non-existent page: https://pds.nasa.gov/datastandards/citing/doi

The landing pages that need to be updated with new Data Object Identifier (DOI) row in the output:

c-suh commented 3 years ago

PR has been opened at https://github.jpl.nasa.gov/PDSEN/pds4-java/pull/133 but am unable to package this into a war. Am getting the following error:

[ERROR] Failed to execute goal on project ds-view: Could not resolve dependencies for project gov.nasa.pds.2010.portal:ds-view:war:2.13.0: Failed to collect dependencies at gov.nasa.pds.2010.registry:registry-core:jar:1.16.0: Failed to read artifact descriptor for gov.nasa.pds.2010.registry:registry-core:jar:1.16.0: Could not transfer artifact gov.nasa.pds.2010.registry:registry-core:pom:1.16.0 from/to pds-repo (https://pds-cm.jpl.nasa.gov/maven2): PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target -> [Help 1]

I've added the root certificate to my JRE truststore but am still encountering this error. Have reached out to @jordanpadams to see if I'm missing anything in my config or anything else.

jordanpadams commented 3 years ago

@c-suh per slack:

  1. go to pds4-java/registry-legacy directory and do a mvn clean install - this installs the registry into your local maven repo
  2. go to the portal/ds-view directory and do a mvn clean install or mvn clean package - this will build the package and grab your local maven jar

I had to comment out a bunch of parent references that were throwing everything off, but I think we should be good to go.

c-suh commented 3 years ago

@jordanpadams thank you; that did the trick. I already had the parent references commented out, but having registry-legacy build the missing jar rather than getting it from pds-repo was what I needed. I'll have this deployed to gamma soon for testing and review.

c-suh commented 3 years ago

@tloubrieu-jpl or @jordanpadams I do not have the permissions to move this issue (from this repo) on the board, but this is ready for view.

jordanpadams commented 3 years ago

@c-suh we will probably need to hold off on deploying this until we actually get this web page working: https://pds.nasa.gov/datastandards/citing/doi .

for https://pds-gamma.jpl.nasa.gov/ds-view/pds/viewBundle.jsp?identifier=urn%3Anasa%3Apds%3Aapollo_seismic_event_catalog&version=1.0, how did the DOI actually appear? Is that actually in the search results? that would be awesome if that was true.

for https://pds-gamma.jpl.nasa.gov/ds-view/pds/viewDataset.jsp?dsid=ODY-M-THM-5-VISGEO-V1.0, this looks like something may have gotten screwed up?

btw, you should now have permissions.

c-suh commented 3 years ago

@jordanpadams thank you for the permissions!

Yes, a citation DOI key already exists in the schema :] For ones that don't have any value, I inserted the placeholder link.

Oops, sorry about viewDataset. I've moved attempted to move this back to 'In Progress' (different set of permissions than reopening/closing an issue?) and will address this soon.

c-suh commented 3 years ago

@jordanpadams sorry for the delay! I pushed a fix and added @tloubrieu-jpl as a reviewer, but let me know if there is anybody else I can add to help this along.

To clarify the above statement: Citation DOI exists in some of the schemas. I'm looking it now and will see if I can provide more details. the schemas used by viewBundle and viewCollection but not in the schema used for viewDataset. I haven't been able to directly query Solr or see the records, but viewDataset uses a class and query parameter specifying it as PDS3 data.

jordanpadams commented 3 years ago

looks great! let's leave this open as "blocked" until we are able to complete NASA-PDS/pds-doi-ui#25

jordanpadams commented 2 years ago

@c-suh if you have time this week, I think I would like to roll out these updates, even if they are not entirely complete

jordanpadams commented 2 years ago

here are some final updates we can work on to get this rolled out:

c-suh commented 2 years ago

@jordanpadams please verify the changes are good to go operational:

jordanpadams commented 2 years ago

@c-suh good for merge!

c-suh commented 2 years ago

@jordanpadams, I don't have the permissions to merge https://github.jpl.nasa.gov/PDSEN/pds4-java/pull/133 (or https://github.jpl.nasa.gov/PDSEN/pds4-java/pull/134).

jordanpadams commented 2 years ago

@c-suh just gave you admin on that repo

tloubrieu-jpl commented 2 years ago

Should change "DATA OBJECT IDENTIFIER (DOI)" to digital...

Otherwise this ticket is ready to be closed

c-suh commented 2 years ago

Fixed and deployed!