Validate 3.5.2 throws this warning on the basic product label "v2_ks-18m.xml" in
v2_ks-18m.zip:
WARNING [warning.label.context_ref_mismatch] line 44: Context reference name mismatch. Value: 'PIONEER VENUS LARGE PROBE' Expected one of: '[PIONEER VENUS MULTIPROBE]'
Checked for duplicates
No - I haven't checked
🐛 Describe the bug
Validate 3.5.2 throws this warning on the basic product label "v2_ks-18m.xml" in v2_ks-18m.zip:
The instrument host specified in the label matches the in <a rel="noreferrer nofollow" target="_blank" href="https://pds.nasa.gov/data/pds4/context-pds4/instrument_host/spacecraft.pvmp.lp_1.0.xml">context product urn:nasa:pds:context:instrument_host:spacecraft.pvmp.lp</a>: "PIONEER VENUS LARGE PROBE".</p>
<p>However, the registered_context_products.json file, which is distributed with Validate 3.5.2, specifies the wrong name:</p>
<pre><code> "name": ["PIONEER VENUS MULTIPROBE"],
"type": ["Spacecraft"],"
"lidvid": "urn:nasa:pds:context:instrument_host:spacecraft.pvmp.lp::1.0"</code></pre>
<p>I ran "validate -u" as Jordan recommended but it did not correct that name in my local JSON file. (It did make a few other updates in that file.) Jordan mentioned those values come directly from the database.</p>
<p>Could the registered_context_products.json file be corrected in the next Validate release?</p>
<h3>🕵️ Expected behavior</h3>
<p>Since the instrument host <name> specified in the label matches the <title> in <a rel="noreferrer nofollow" target="_blank" href="https://pds.nasa.gov/data/pds4/context-pds4/instrument_host/spacecraft.pvmp.lp_1.0.xml">context product urn:nasa:pds:context:instrument_host:spacecraft.pvmp.lp</a>, I expected to get no warning message.</p>
<h3>📜 To Reproduce</h3>
<ol>
<li>Run validate 3.5.2 (confirm it is using the registered_context_products.json file that is distributed with that version) on the attached label: <code>> validate v2_ks-18m.xml</code></li>
</ol>
<h3>🖥 Environment Info</h3>
<ul>
<li>Version of this PDS software: Validate 3.5.2</li>
<li>Operating System: macOS Sonoma 14.7</li>
<li>Java version "21.0.4" 2024-07-16 LTS
Java(TM) SE Runtime Environment (build 21.0.4+8-LTS-274)
Java HotSpot(TM) 64-Bit Server VM (build 21.0.4+8-LTS-274, mixed mode, sharing)</li>
</ul>
<h3>📚 Version of Software Used</h3>
<p>Validate 3.5.2</p>
<h3>🩺 Test Data / Additional context</h3>
<p>The attached zip file "v2_ks-18m.zip" includes the product data file "v2_ks-18m.dat".</p>
<h3>🦄 Related requirements</h3>
<p>🦄 #xyz</p>
<h3>⚙️ Engineering Details</h3>
<p><em>No response</em></p>
<h3>🎉 Integration & Test</h3>
<p><em>No response</em></p> </div>
</div>
<div class="comment">
<div class="user">
<a rel="noreferrer nofollow" target="_blank" href="https://github.com/jordanpadams"><img src="https://avatars.githubusercontent.com/u/33492486?v=4" />jordanpadams</a>
commented
<strong> 1 month ago</strong> </div>
<div class="markdown-body">
<p>@smclaughlin7 we currently only match the <code>Instrument_Host.Name</code> value in order to encourage the highest level of consistency across the archive. The title can be considered a "display title", which is not necessarily appropriate for archive metadata. You are welcome to disable the check if you do not want to make the appropriate updates for this.</p> </div>
</div>
<div class="comment">
<div class="user">
<a rel="noreferrer nofollow" target="_blank" href="https://github.com/smclaughlin7"><img src="https://avatars.githubusercontent.com/u/71351072?v=4" />smclaughlin7</a>
commented
<strong> 1 month ago</strong> </div>
<div class="markdown-body">
<p>@jordanpadams My concern is that the current registered_context_products.json file specifies an incorrect and misleading name/display title for the Pioneer Venus Large Probe spacecraft/instrument_host (urn:nasa:pds:context:instrument_host:spacecraft.pvmp.lp::1.0). The Large Probe was one of five spacecraft/instrument_hosts that comprised the "Multiprobe" component of the Pioneer Venus mission/investigation.</p>
<p>In the context JSON file, the name for the Large Probe entry should be changed
from:
"PIONEER VENUS MULTIPROBE"
to
"PIONEER VENUS LARGE PROBE"</p>
<p>Looping in @Martian-Dustdevil (Lynn -- Great handle!) because he did all the heavy lifting for us on the instrument_host context products for the Pioneer Venus Large/Day/Night/North/Bus spacecraft.</p> </div>
</div>
<div class="comment">
<div class="user">
<a rel="noreferrer nofollow" target="_blank" href="https://github.com/jordanpadams"><img src="https://avatars.githubusercontent.com/u/33492486?v=4" />jordanpadams</a>
commented
<strong> 1 month ago</strong> </div>
<div class="markdown-body">
<p>@smclaughlin7 sorry for the misunderstanding. This needs to be updated in the context products themselves. Not validate. We are in the process of doing a scrub of these so I will add this to my list.</p> </div>
</div>
<div class="comment">
<div class="user">
<a rel="noreferrer nofollow" target="_blank" href="https://github.com/Martian-Dustdevil"><img src="https://avatars.githubusercontent.com/u/76966696?v=4" />Martian-Dustdevil</a>
commented
<strong> 1 month ago</strong> </div>
<div class="markdown-body">
<p>So to be clear -- the <title> of the instrument_host product is currently "PIONEER VENUS LARGE PROBE"; the <name> listed under <Instrument_Host> in the same product is "PIONEER VENUS MULTIPROBE" ... Specifically what needs to happen in the context product is that the <name> for the Large Probe needs to be changed to "PIONEER VENUS LARGE PROBE" </p> </div>
</div>
<div class="comment">
<div class="user">
<a rel="noreferrer nofollow" target="_blank" href="https://github.com/smclaughlin7"><img src="https://avatars.githubusercontent.com/u/71351072?v=4" />smclaughlin7</a>
commented
<strong> 1 month ago</strong> </div>
<div class="markdown-body">
<p>@jordanpadams Sorry, my description of this 'bug' was not very clear!
@Martian-Dustdevil Thanks for clarifying <Instrument_Host> needs to be changed from "PIONEER VENUS MULTIPROBE" to "PIONEER VENUS LARGE PROBE" in the context product <code>urn:nasa:pds:context:instrument_host:spacecraft.pvmp.lp</code>.</p> </div>
</div>
<div class="page-bar-simple">
</div>
<div class="footer">
<ul class="body">
<li>© <script>
document.write(new Date().getFullYear())
</script> Githubissues.</li>
<li>Githubissues is a development platform for aggregating issues.</li>
</ul>
</div>
<script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script>
<script src="/githubissues/assets/js.js"></script>
<script src="/githubissues/assets/markdown.js"></script>
<script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script>
<script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script>
<script>
hljs.highlightAll();
</script>
</body>
</html>