search

NASA-PDS / validate

Validates PDS4 product labels, data and PDS3 Volumes
https://nasa-pds.github.io/validate/
Apache License 2.0
16 stars 11 forks source link

New requirement to ensure is exactly one digit to the left of the decimal point for the specifier `e` or `E` and fix tests #1042

Closed al-niessner closed 1 month ago

al-niessner commented 1 month ago

🗒️ Summary

Fix field regular expresion

⚙️ Test Data and/or Report

All automated unit/regression tests pass

♻️ Related Issues

Closes #992

al-niessner commented 1 month ago

No. Something is deeply broken within the test portion of this repo.

On Tue, Oct 22, 2024, 15:13 Sean Kelly @.***> wrote:

@.**** commented on this pull request.

@al-niessner https://github.com/al-niessner am I running these tests wrong?

$ echo $JAVA_HOME/Library/Java/JavaVirtualMachines/jdk-17.0.1.jdk/Contents/Home $ mvn --versionJava version: 17.0.1, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-17.0.1.jdk/Contents/HomeDefault locale: en_US, platform encoding: UTF-8OS name: "mac os x", version: "15.0.1", arch: "x86_64", family: "mac" $ git statusOn branch issue_992Your branch is up to date with 'origin/issue_992'. nothing to commit, working tree clean $ mvn clean test[INFO] Scanning for projects...[INFO] Inspecting build with total of 1 modules...[INFO] Installing Nexus Staging features:[INFO] ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin[INFO] [INFO] -----------------------< gov.nasa.pds:validate >------------------------[INFO] Building gov.nasa.pds:validate 3.6.0-SNAPSHOT[INFO] from pom.xml[INFO] --------------------------------[ jar ]---------------------------------[INFO] [INFO] --- clean:3.2.0:clean (default-clean) @ validate ---[INFO] Deleting /Users/kelly/Documents/Clients/JPL/PDS/Development/nasa-pds/validate/target[INFO] [INFO] --- buildnumber:3.2.1:create (default) @ validate ---[INFO] Storing buildNumber: 2024-10-22 17:00:52 at timestamp: 1729634452655[INFO] Executing: /bin/sh -c cd '/Users/kelly/Documents/Clients/JPL/PDS/Development/nasa-pds/validate' && 'git' 'symbolic-ref' 'HEAD'[INFO] Working directory: /Users/kelly/Documents/Clients/JPL/PDS/Development/nasa-pds/validate[INFO] Storing scmBranch: issue_992…[ERROR] Tests run: 270, Failures: 60, Errors: 0, Skipped: 23[INFO] [INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 10:29 min[INFO] Finished at: 2024-10-22T17:11:17-05:00[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.3.0:test (default-test) on project validate: There are test failures.[ERROR] [ERROR] Please refer to /Users/kelly/Documents/Clients/JPL/PDS/Development/nasa-pds/validate/target/surefire-reports for the individual test results.[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.[ERROR] -> [Help 1]…

— Reply to this email directly, view it on GitHub https://github.com/NASA-PDS/validate/pull/1042#pullrequestreview-2386489691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIUBIXC54SVW36MDARPODTZ43EZRAVCNFSM6AAAAABQNJM4DCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBWGQ4DSNRZGE . You are receiving this because you were mentioned.Message ID: @.***>

nutjob4life commented 1 month ago

@al-niessner no worries, no rush! I'll stand by for now. (Well, not really … I'll sit by because I'm already on my chair 😆)

al-niessner commented 1 month ago

@jordanpadams @nutjob4life @tloubrieu-jpl

Can I please get a quick review and merge so that I can repair some of the other branches. Thanks.

nutjob4life commented 1 month ago

You got it @al-niessner! I just pulled and am running mvn test.