NASA-PDS / validate

Validates PDS4 product labels, data and PDS3 Volumes
https://nasa-pds.github.io/validate/
Apache License 2.0
16 stars 11 forks source link

Validate misses flagging a warning about the completeness and accuracy of collection inventories #654

Closed mace-space closed 1 year ago

mace-space commented 1 year ago

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

Referential integrity check appears to miss warnings about collection_data.csv and data products in a bundle of raw RSS Voyager data (link to data below).

Transfer manifest contains the following entries:

urn:nasa:pds:voyager2_rss_jupiter_raw:browse:vg2j_14mr_1979191t131727::1.0      ./browse/vg2j_14mr_1979191t131727.xml
urn:nasa:pds:voyager2_rss_jupiter_raw:data:vg2j_14mr_1979191t131727::1.0        ./data/vg2j_14mr_1979191t131727.xml 

and the corresponding data and browse collections do contain these files.

However, the collection_data.csv lists: P,urn:nasa:pds:voyager2_rss_jupiter_raw:data:vg2j_14mr_1979191t131728::1.0 ending in 8, rather than 7.

(The collection_browse.csv does list the correct file: P,urn:nasa:pds:voyager2_rss_jupiter_raw:browse:vg2j_14mr_1979191t131727::1.0)

🕵️ Expected behavior

I expected Validate to at least flag a warning, but everything passed. Validate ought to verify the completeness and accuracy of collection inventories.

Request that Validate flags a warning about referential integrity if the collection CSV members and files in the collection do not match.

📜 To Reproduce

Bundle can be found at https://pds-rings.seti.org/review-data/voyager_rss_jupiter_raw/

🖥 Environment Info

No response

📚 Version of Software Used

Validate 3.0.3, Validate 3.2.0

🩺 Test Data / Additional context

No response

🦄 Related requirements

No response

⚙️ Engineering Details

No response

jordanpadams commented 1 year ago

@mace-space would you mind attaching the run log if you still have it?

mace-space commented 1 year ago

I don't think it is an issue with Validate after all, but rather due to the options chosen? I attach two logs:

jordanpadams commented 1 year ago

@mace-space correct. that is the issue. for production validation, you pretty much want to always use the pds4.bundle rule, unless you are running validate multiple times in a pipeline of some kind. let us know if you run into any other issues.