NASA-PDS / wds-react-legacy

PDS Web Design System - React Implementation
https://github.com/NASA-PDS/wds-react
Apache License 2.0
1 stars 1 forks source link

DOI Search updates per testing #10

Closed tloubrieu-jpl closed 2 years ago

tloubrieu-jpl commented 2 years ago

@jordanpadams commented on Thu Nov 18 2021


@tloubrieu-jpl commented on Thu Nov 18 2021

@jordanpadams I would move the frontend ticket to pds-wds-react since the module will stay there.

eddiesarevalo commented 2 years ago

Identifiers should be LIDVID for PDS4 and data set id for PDS3 - I think this is possible from the data, but we want to display the data set ID if at all possible. the PDS4-equivalent identifier doesn't make sense to anyone outside of JPL @jordanpadams Should this be changed from the server side? Here is the content for a single search result:

{
   doi: "10.17189/1517634"

   identifier: "urn:nasa:pds:maven.rose.raw:data.tnf::1.8"

   node: "ppi"

   status: "findable"

   submitter: "pds-operator@jpl.nasa.gov"
   
title: "MAVEN ROSE Radio Science Tracking and Navigation File (TNF) Data Collection"

   update_date: "2020-06-13T00:02:07+08:00"
}

Either the identifier should be changed depending on if the product is PDS4 or PDS3. Or we can add another field called data_set_id that if the search result is PDS3, it will be populated with the data set ID

Change page title from "PDS: Tools" to "PDS: DOI Search" @jordanpadams This was changed from pds-gamma website so there is no record on github. Is this image what you had in mind for the title? Screen Shot 2021-12-06 at 3 27 05 PM

How to translate data set IDs with a slash for search - data set ID search does not work if they have a slash in the data set id @jordanpadams Do you happen to have an example of this? I tried https://pds-gamma.jpl.nasa.gov/tools/doi/#/search/10.17189/1517634 and it returns the result.

searches need to be case insensitive @jordanpadams I can do a quick fix for this by just making all search text to lower case but that might not return the correct results. The server side should probably do the logic to find the right results.

sortable by each columns @jordanpadams @collinss-jpl Is there a way to do this easily on the server side? For example something like &sort=title desc If not I can do this client side but the logic might be more complex as the returned json result array has to be sorted which would mess with the pagination.

jordanpadams commented 2 years ago

@eddiesarevalo

Identifiers should be LIDVID for PDS4 and data set id for PDS3 - I think this is possible from the data, but we want to display the data set ID if at all possible. the PDS4-equivalent identifier doesn't make sense to anyone outside of JPL @jordanpadams Should this be changed from the server side? Here is the content for a single search result:

Either the identifier should be changed depending on if the product is PDS4 or PDS3. Or we can add another field called data_set_id that if the search result is PDS3, it will be populated with the data set ID

we can table this for now. we may need to get this data added to the metadata in the service

Change page title from "PDS: Tools" to "PDS: DOI Search" @jordanpadams This was changed from pds-gamma website so there is no record on github. Is this image what you had in mind for the title?

I was talking about this:

Screen Shot 2021-12-06 at 7 58 36 PM

but it doesn't really matter.

How to translate data set IDs with a slash for search - data set ID search does not work if they have a slash in the data set id @jordanpadams Do you happen to have an example of this? I tried https://pds-gamma.jpl.nasa.gov/tools/doi/#/search/10.17189/1517634 and it returns the result.

This does not work: https://pds-gamma.jpl.nasa.gov/tools/doi/#/search/CO-V/E/J/S/SS-RPWS-3-RDR-LRFULL-V1.0 . The slashes in the data-set-id should probably just be translated to *, e.g. https://pds-gamma.jpl.nasa.gov/tools/doi/#/search/co-v*e*j*s*ss-rpws-3-rdr-lrfull-v1.0 (note: the current DOI service on pds-gamma does not contain the fix for handling upper case)

searches need to be case insensitive @jordanpadams I can do a quick fix for this by just making all search text to lower case but that might not return the correct results. The server side should probably do the logic to find the right results.

This has been updated already, it just needs to be deployed. @collinss-jpl @tloubrieu-jpl once we get the latest bug fixes in, can we upgrade the DOI Service on pds-gamma?

sortable by each columns @jordanpadams @collinss-jpl Is there a way to do this easily on the server side? For example something like &sort=title desc If not I can do this client side but the logic might be more complex as the returned json result array has to be sorted which would mess with the pagination.

copy that. let's table this functionality to a later upgrade

collinss-jpl commented 2 years ago

@jordanpadams @eddiesarevalo @tloubrieu-jpl I've just created a release/2.1.1 branch and will try to get the service on gamma updated today so the case-insensitive search is available.

collinss-jpl commented 2 years ago

@jordanpadams @eddiesarevalo @tloubrieu-jpl I've just created a release/2.1.1 branch and will try to get the service on gamma updated today so the case-insensitive search is available.

Service has been updated to 2.1.1 on pds-gamma, and the DOI API has been restarted. Let me know on slack if you run into any issues.

jordanpadams commented 2 years ago

@eddiesarevalo on additional update if possible:

jordanpadams commented 2 years ago

@eddiesarevalo are the changes above done and merged? or are they still on a branch?

eddiesarevalo commented 2 years ago

@jordanpadams Everything was pushed up except for the trim edge whitespace, which I just pushed up. This is all in a branch https://github.com/NASA-PDS/pds-wds-react/commits/embed-and-npm-builder

nutjob4life commented 2 years ago

Moving to review

jordanpadams commented 2 years ago

@eddiesarevalo can we create a PR so we can merge this to main? or are we not doing that just yet?

eddiesarevalo commented 2 years ago

@jordanpadams We need to think about what to do with the current main. It is completely different and contains the "PDS App Bar" We should probably add the PDS app bar to this repo.

jordanpadams commented 2 years ago

@eddiesarevalo copy that. lets talk about it at the breakout.