search

NASA-Planetary-Science / sbpy

A Python package for small bodies research
https://sbpy.org/
Other
67 stars 34 forks source link

Fix `DataClass.__setitem__` #364

Closed jianyangli closed 2 years ago

jianyangli commented 2 years ago

This fix allows DataClass.__setitem__ to set an existing column with an alternative name, rather than adding a new column.

pep8speaks commented 2 years ago

Hello @jianyangli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-07-19 14:44:22 UTC
jianyangli commented 2 years ago

I also improved _translate_columns and __contains__. The change and rationale are in the commit comments. Please let me know if those make sense or perhaps overengineered. Thanks.