search

NASA-Planetary-Science / sbpy

A Python package for small bodies research
https://sbpy.org/
Other
66 stars 34 forks source link

Add CALSPEC model solar spectrum #371

Closed mkelley closed 1 year ago

mkelley commented 1 year ago

Adding support for a R=5000 model solar spectrum from STScI's CALSPEC database.

mkelley commented 1 year ago

Requires #370 .

codecov[bot] commented 1 year ago

Codecov Report

Merging #371 (4ba3da1) into main (8950548) will decrease coverage by 0.04%. The diff coverage is 77.50%.

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   76.10%   76.06%   -0.04%     
==========================================
  Files          78       78              
  Lines        6921     6928       +7     
==========================================
+ Hits         5267     5270       +3     
- Misses       1654     1658       +4
Impacted Files Coverage Δ
sbpy/calib/tests/test_sun.py 87.03% <76.92%> (-3.16%) :arrow_down:
sbpy/calib/solar_sources.py 100.00% <100.00%> (ø)
mkelley commented 1 year ago

The decrease in coverage is due to adding a remote test. So, this is ready for review.

mkelley commented 1 year ago

It isn't important, just a style preference. I like to use the Black formatter and it automatically does the change "The main reason to standardize on a single form of quotes is aesthetics. Having one kind of quotes everywhere reduces reader distraction." https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#strings