NASA-Planetary-Science / sbpy

A Python package for small bodies research
https://sbpy.org/
Other
66 stars 34 forks source link

New coma continuum models and convert Afrho/Efrho to/from cross-sectional area. #376

Open mkelley opened 1 year ago

mkelley commented 1 year ago

Draft coma continuum models: reddened Afρ model (scattered light) + εfρ model (thermal emission).

Also, add methods to Afrho and Efrho to convert to and from cross-sectional area.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (1315915) 77.52% compared to head (05beba4) 76.73%.

Files Patch % Lines
sbpy/activity/dust.py 51.21% 20 Missing :warning:
sbpy/activity/tests/test_dust.py 56.52% 20 Missing :warning:
sbpy/spectroscopy/tests/test_coma.py 84.40% 17 Missing :warning:
sbpy/spectroscopy/coma.py 96.29% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #376 +/- ## ========================================== - Coverage 77.52% 76.73% -0.80% ========================================== Files 81 83 +2 Lines 7096 7366 +270 ========================================== + Hits 5501 5652 +151 - Misses 1595 1714 +119 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pep8speaks commented 6 months ago

Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 340:80: E501 line too long (84 > 79 characters) Line 663:80: E501 line too long (84 > 79 characters) Line 664:80: E501 line too long (84 > 79 characters)

Line 217:80: E501 line too long (88 > 79 characters) Line 384:80: E501 line too long (82 > 79 characters)

Line 33:80: E501 line too long (80 > 79 characters) Line 67:80: E501 line too long (83 > 79 characters) Line 263:80: E501 line too long (86 > 79 characters)

Line 108:80: E501 line too long (87 > 79 characters) Line 274:80: E501 line too long (84 > 79 characters) Line 411:80: E501 line too long (86 > 79 characters) Line 517:80: E501 line too long (82 > 79 characters) Line 543:80: E501 line too long (85 > 79 characters) Line 548:80: E501 line too long (85 > 79 characters)

Line 116:80: E501 line too long (86 > 79 characters)

Comment last updated at 2024-01-18 01:21:19 UTC
mkelley commented 6 months ago

Closes #110