Open mkelley opened 1 year ago
Attention: 60 lines
in your changes are missing coverage. Please review.
Comparison is base (
1315915
) 77.52% compared to head (05beba4
) 76.73%.
Files | Patch % | Lines |
---|---|---|
sbpy/activity/dust.py | 51.21% | 20 Missing :warning: |
sbpy/activity/tests/test_dust.py | 56.52% | 20 Missing :warning: |
sbpy/spectroscopy/tests/test_coma.py | 84.40% | 17 Missing :warning: |
sbpy/spectroscopy/coma.py | 96.29% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
sbpy/activity/dust.py
:Line 340:80: E501 line too long (84 > 79 characters) Line 663:80: E501 line too long (84 > 79 characters) Line 664:80: E501 line too long (84 > 79 characters)
sbpy/activity/tests/test_dust.py
:Line 217:80: E501 line too long (88 > 79 characters) Line 384:80: E501 line too long (82 > 79 characters)
sbpy/spectroscopy/coma.py
:Line 33:80: E501 line too long (80 > 79 characters) Line 67:80: E501 line too long (83 > 79 characters) Line 263:80: E501 line too long (86 > 79 characters)
sbpy/spectroscopy/sources.py
:Line 108:80: E501 line too long (87 > 79 characters) Line 274:80: E501 line too long (84 > 79 characters) Line 411:80: E501 line too long (86 > 79 characters) Line 517:80: E501 line too long (82 > 79 characters) Line 543:80: E501 line too long (85 > 79 characters) Line 548:80: E501 line too long (85 > 79 characters)
sbpy/spectroscopy/tests/test_coma.py
:Line 116:80: E501 line too long (86 > 79 characters)
Closes #110
Draft coma continuum models: reddened Afρ model (scattered light) + εfρ model (thermal emission).
Also, add methods to
Afrho
andEfrho
to convert to and from cross-sectional area.