Closed mkelley closed 1 month ago
Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.55%. Comparing base (
1315915
) to head (4812c20
). Report is 20 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
The
Afrho
andEfrho
classes can take aQuantity
or anAperture
as an input for the photometric aperture radius, and they will convert it to a coma equivalent radius, as needed. While writing new code for PR #376, I needed to repeat that same Quantity/Aperture conversion code, and also repeat tests for each case. This seemed like an opportunity for an enhancement that could simplify the code.Each of the
Aperture
classes can be converted to an effective circular aperture based on the assumption of a 1/rho coma. This PR enables any of theAperture
classes to directly initialize aCircularAperture
object using that coma equivalent aperture conversion:Or, a radius may be given as a
Quantity
, in which case the "coma equivalent" radius is the same value:With this change, the
Afrho
,Efrho
, and any similar code that needs the effective aperture radius for a 1/rho coma can pass their input parameters toCircularAperture
without the need to test forQuantity
vs.Aperture
input, and the developers do not need to be concerned with the conversions for testing coverage: