search

NASA-SW-VnV / ikos

Static analyzer for C/C++ based on the theory of Abstract Interpretation.
Other
2.36k stars 171 forks source link

Adjust check of sqlite3 version on MacOS (#223). #235

Closed ivanperez-keera closed 1 year ago

ivanperez-keera commented 1 year ago

Installation on MacOS fails partly because a sqlite3-related assertion in one of the pre-installation checks does not hold on MacOS. More specifically, the assertion in question is whether the version numbers of sqlite3 in the string SQLITE_VERSION and the one returned by sqlite3_libversion are the same. This is a known issue with the sqlite3 library, and is external to IKOS.

This commit adds a condition around that assertion so that it is not checked on MacOS.

ivanperez-keera commented 1 year ago

Please let me know if you try this and it works/doesn't.

If it does work for you, please don't merge this right away. There's a few simultaneous PRs, and I'd like to merge them in a specific way. Thanks! :)

maxmunzel commented 1 year ago

I tar-g-zipped the repo at the PR commit, and tweaked the brew script:

class Ikos < Formula
  include Language::Python::Virtualenv
  desc "Static analyzer for C/C++ based on the theory of Abstract Interpretation"
  homepage "https://github.com/nasa-sw-vnv/ikos"
  url "http://demo.maxnagy.com:8000/get?q=qJ-ZqHFoThrGy3knp8p2XQ"  # < -- here we need to add a tag and add the corresponding id
  sha256 "1017e7e4097f9b66f0431eaf85972ba57a3aa735e48d8c89510119a2f76b6fa1" # < -- this also needs to be adapted then
  license "MIT"
  revision 1
  version "42.42.42"  # < -- added this, brew complained without it (maybe something changed there?)

Afterwards the install just worked. Thanks for your work :)