search

NASA-Tensegrity-Robotics-Toolkit / NTRTsim

The NASA Tensegrity Robotics Toolkit Simulator, a physics based simulator to research the design and control of tensegrity robots.
Apache License 2.0
162 stars 81 forks source link

Multiple BuildBot runs on a single merge #56

Open PerryBhandal opened 10 years ago

PerryBhandal commented 10 years ago

For some reason when we do a merge request, the first commit runs as one build bot test, then buildbot runs again with all remaining commits.

Brian experienced this yesterday, and I experienced the same thing today.

The best way to avoid this is likely to have a 'commit window' after a new commit is received. BuildBot will wait for that time period after it sees a new commit to let any other commits roll in. I believe this should resolve it, I just need to research whether BuildBot already has that feature or if we need to implement it ourselves.

brtietz commented 10 years ago

One note to devs: this is still a bug, so if you get a "build failed" email, check the website (http://ntrt.perryb.ca/bb/builders/master) to see if the most recent build succeeded. If it did, its likely buildbot aborted a previous commit to work on the latest. If that latest build worked, you're successful.

PerryBhandal commented 10 years ago

I took a look at it after posting the issue and I didn't find any easy way to create a commit window. I'm also fairly certain that wouldn't resolve the issue anyway: it doesn't seem to be a timing fluke as I initially assumed. I don't know exactly what's causing it, but I wonder whether a webhook (as opposed to the polling approach we currently use) would help. It's a shot in the dark, but that's the best idea I have at the moment.

My fall semester has just started and it's quite busy at the moment. I'll be continuing work on my thesis (and NTRT) come late October -- I'll try to find a more concrete resolution then. I'm assuming it's just a mild inconvenience, but if it's causing any serious problems I'm unaware of please let me know and I'll try to resolve it sooner.

vsunspiral commented 10 years ago

thanks for your ongoing support on NTRT! Good luck with your classes! vytas

On Sep 23, 2014, at 2:37 PM, Perry Bhandal notifications@github.com wrote:

I took a look at it after posting the issue and I didn't find any easy way to create a commit window. I'm also fairly certain that wouldn't resolve the issue anyway: it doesn't seem to be a timing fluke as I initially assumed. I don't know exactly what's causing it, but I wonder whether a webhook (as opposed to the polling approach we currently use) would help. It's a shot in the dark, but that's the best idea I have at the moment.

My fall semester has just started and it's quite busy at the moment. I'll be continuing work on my thesis (and NTRT) come late October -- I'll try to find a more concrete resolution then. I'm assuming it's just a mild inconvenience, but if it's causing any serious problems I'm unaware of please let me know and I'll try to resolve it sooner.

— Reply to this email directly or view it on GitHub.

Vytas SunSpiral
Dynamic Tensegrity Robotics Lab cell- 510-847-4600 Office: 650-604-4363 N269 Rm. 100

Stinger Ghaffarian Technologies Intelligent Robotics Group NASA Ames Research Center

I will not tiptoe cautiously through life only to arrive safely at death.

PerryBhandal commented 9 years ago

I spent some time looking into the GitHub webhook for buildbot. Unfortunately it's not very well documented, and it (BuildBot) is throwing an error whenever the GH hook is called. Specifically, it's complaining about the absence of the 'name' key, despite it being included the POST request. Fixing it would require that I grab BuildBot's source and re-create our setup, then try to trace through a hook call -- a fairly time intensive process.

Given how involving that will be, I'm going to leave this issue unresolved for now. As far as I understand, it's just a minor annoyance for everyone. That said, if this is causing serious problems for anyone, let me know.