search

NASA-Tournament-Lab / CoECI-OPM-Service-Credit-Redeposit-Deposit-Application

This repository houses code for the United States Office of Personnel Management Service Credit Re-deposit/Deposit (SCRD) Application.
Apache License 2.0
6 stars 9 forks source link

Service History - Show Calculation Report #37

Closed pizza-and-dog closed 10 years ago

pizza-and-dog commented 10 years ago
  1. Change needs to be made to: -----Create New Account > Service History -----View Account > Service History
  2. Make the Show Calculation Report look exactly like the calculation explanation (make the formatting a bit easier to read) as the attached images.
pizza-and-dog commented 10 years ago

4_expanded_calc 3_expanded_calc 2_expanded_calc 1_expanded_calc

pizza-and-dog commented 10 years ago

Code committed and OPM emailed about the update.

pizza-and-dog commented 10 years ago

@mabenner & @psisrael, I am closing this issue. Please let me know if it needs to be reopened.

dcieslicki commented 10 years ago

The Calc explanation is still not acceptable. Please look at our examples carefully. The calc explanation needs to explain how it calculated the principal amount. (i.e. the $92.86). If you look at our calc, it shows what the deduction rate is and what the hourly rate of $2.80 translates to in earnings (2.80 x 2080 x .227778). So the total earnings are $1326.58 and .07% of $1326.58 is $92.86. We absolutely need this for all audits that are done. In addition, if you look at our calc explanation, the interest is rounded after each year to dollars and cents, just as we specified in our requirements. Finally, the summary at the end of the calc explanation is in dollars and cents only, as we also specified in our requirements.

pizza-and-dog commented 10 years ago

@dcieslicki, are there any other items other than the changes mentioned in the comment above?

dcieslicki commented 10 years ago

So just to recap :
The requirements are:

Principal Computation: Each Service Period Calculated broken down by : • Years/months/days in period and the corresponding time factor • The deduction rate • The pay rate (annual salary, hourly rate, etc) converted to earnings for that period (pay rate multiplied by the time factor for the period) • The amount of deduction for the earnings • A running total of earnings • A running total of deductions • Total deposit or redeposit principal amount at end of Principal Computation

Interest Computation: Each Service Period broken down by: • Statement of Interest Calculation End Date • Years/months/days in period and the corresponding time factor • The midpoint for a deposit (i.e. point at which interest begins) • The refund date for a redeposit (i.e. point at which interest begins) • The initial deposit/redeposit amount • The start year time factor • The interest rate • Amount of interest for the time period expressed in dollars/cents (rounded to 2 digits at the end of each calendar year) • Running balance of deposit/redeposit with interest

Totals in dollars and cents showing the principal, interest, (payments made if applicable) and total amount due for the individual billing category(ies).

pizza-and-dog commented 10 years ago

Got it, will make these changes.

pizza-and-dog commented 10 years ago

Fixed, will send code to OPM for review.

dcieslicki commented 10 years ago

This is still unstable. In many cases, it will not show calculation until after I have saved the calculation, left the account and then came back in. In other accounts, it showed the calculation when I requested it as of running the calculation.

pizza-and-dog commented 10 years ago

@dcieslicki, the "Show Calculation" button will not appear until after you have either ran a calculation, or ran a calculation and saved it. If you haven't ran it, the button won't appear. Please specify the exact steps to reproduce as I am unable to reproduce this.

dcieslicki commented 10 years ago

I did run it. You have to run the calculation before you get a result and then you need to check the result to ensure it calculated correctly, which is why we need to see the “Show Calculation” after we run the calculation. However, this feature does not always show the calculation, even after I have saved it. Here are two examples:

[cid:image003.jpg@01CF9AAF.AA3F1950] System does not show the calculation as of running or as of saving the calculation [cid:image004.jpg@01CF9AAF.AA3F1950] FERS Deposit with Leave Without Pay Service Does not show calculation

From: Rashid Sial [mailto:notifications@github.com] Sent: Tuesday, July 08, 2014 12:17 PM To: nasa/SCRD Cc: Cieslicki, Donna G Subject: Re: [SCRD] Service History - Show Calculation Report (#37)

@dcieslickihttps://github.com/dcieslicki, the "Show Calculation" button will not appear until after you have either ran a calculation, or ran a calculation and saved it. If you haven't ran it, the button won't appear. Please specify the exact steps to reproduce as I am unable to reproduce this.

— Reply to this email directly or view it on GitHubhttps://github.com/nasa/SCRD/issues/37#issuecomment-48362315.

pizza-and-dog commented 10 years ago

@dcieslicki, please attach the images via GitHub, replying via email with an image won't work.

dcieslicki commented 10 years ago

I enter service; then I press "run calculation" then I press "show calculation" and nothing shows up. Then I press "save calculation" then I press "show calculation" and still nothing shows up. Then I leave the account and go back into the account and press "show calculation" and that is when the calculation explanation appears. We need the show calculation to work right after we run the calculation so that we can determine whether or not we want to save it.

pizza-and-dog commented 10 years ago

@dcieslicki, you can only attach a screenshot while on the GitHub website, and not via email. Please attach the screenshots directly to this ticket by using the "Attach images by dragging & dropping, selecting them, or pasting from the clipboard." link below (which appears when you make a comment on a ticket).

pizza-and-dog commented 10 years ago

Fixed, now ready for OPM review (after the code has been deployed by OPM).

dcieslicki commented 10 years ago

We are still not getting the show calculation to display once we run or save a calculation.

pizza-and-dog commented 10 years ago

@dcieslicki, Show Calculation will work on an existing account, but not in the Create New Account wizard. I will open a new ticket specifically for that defect, and close this one.

psisrael commented 10 years ago

reopen immediately

From: Rashid Sial [notifications@github.com] Sent: Sunday, July 13, 2014 9:31 AM To: nasa/SCRD Cc: Israel, Pamela S Subject: Re: [SCRD] Service History - Show Calculation Report (#37)

Closed #37https://github.com/nasa/SCRD/issues/37.

— Reply to this email directly or view it on GitHubhttps://github.com/nasa/SCRD/issues/37#event-141007177.

psisrael commented 10 years ago

do not close the ticket

From: Rashid Sial [notifications@github.com] Sent: Sunday, July 13, 2014 9:31 AM To: nasa/SCRD Cc: Israel, Pamela S Subject: Re: [SCRD] Service History - Show Calculation Report (#37)

@dcieslickihttps://github.com/dcieslicki, Show Calculation will work on an existing account, but not in the Create New Account wizard. I will open a new ticket specifically for that defect, and close this one.

— Reply to this email directly or view it on GitHubhttps://github.com/nasa/SCRD/issues/37#issuecomment-48840630.

pizza-and-dog commented 10 years ago

hi @psisrael, thank you for the feedback. The feedback on this ticket has been implemented.

I created a new ticket to handle the last comment from Donna: https://github.com/nasa/SCRD/issues/72

I need to ensure that I have actionable tickets open in GitHub for the members to work off of.

psisrael commented 10 years ago

That needs to be verified...no tickets are to be closed without our confirmation. Reopen ticket.

Sent from my iPad

On Jul 13, 2014, at 9:57 AM, "Rashid Sial" notifications@github.com<mailto:notifications@github.com> wrote:

hi @psisraelhttps://github.com/psisrael, thank you for the feedback. The feedback on this ticket has been implemented.

I created a new ticket to handle the last comment from Donna: #72https://github.com/nasa/SCRD/issues/72

I need to ensure that I have actionable tickets open in GitHub for the members to work off of.

— Reply to this email directly or view it on GitHubhttps://github.com/nasa/SCRD/issues/37#issuecomment-48841176.

pizza-and-dog commented 10 years ago

@psisrael - I have reopened the ticket.

@dcieslicki - please verify that I can close this ticket. Please note that the Show Calculation button works on existing accounts fine, but that we need to fix it for new accounts created in the Create New Account wizard. Please see this new ticket which has been created to handle that: https://github.com/nasa/SCRD/issues/72

psisrael commented 10 years ago

no, that's different

From: Rashid Sial [notifications@github.com] Sent: Monday, July 14, 2014 5:48 PM To: nasa/SCRD Cc: Israel, Pamela S Subject: Re: [SCRD] Service History - Show Calculation Report (#37)

Closed #37https://github.com/nasa/SCRD/issues/37.

— Reply to this email directly or view it on GitHubhttps://github.com/nasa/SCRD/issues/37#event-141448091.

pizza-and-dog commented 10 years ago

Unfortunately, I don't have the additional information required. The assembly is launching tonight, and if I don't get this info soon, it won't be included - sorry about this.

psisrael commented 10 years ago

It is on the screenshots sent earlier...same steps, same results...two different defects. You have the info...just duplicate what you added for the other one, and point to the two different balances, one caused by not applying four payments, and one by pulling 12K out of thin air. Can't make it any simpler than that.

Sent from my iPad

On Jul 14, 2014, at 6:04 PM, "Rashid Sial" notifications@github.com<mailto:notifications@github.com> wrote:

Unfortunately, I don't have the additional information required. The assembly is launching tonight, and if I don't get this info soon, it won't be included - sorry about this.

— Reply to this email directly or view it on GitHubhttps://github.com/nasa/SCRD/issues/37#issuecomment-48966305.