Payment History - Reverse Payment Button

[pizza-and-dog]

1. Go to View Account > Payment History
2. Highlight a row.
3. Click the Reverse Payment button.
4. Modal window appears, asking user to select from a drop down as to why the payment is being reversed.
5. Once a reason is selected the technician will click “ok” and the status of the payment should be changed to ”Reversal- Pending Approval”. ERROR: this is not occurring.
6. This action should then appear on the supervisors approval list for approval on the Approval tab. ERROR: this is not occurring.
7. Once the payment is approved on the Approval tab, the payment should be in “Pending” status until the overnight batch process is ran.
8. The next day the status should appear as “Reversal-Posted Complete.” This is the process under the “Receivables Technician” Role.

[joelc]

The "Transaction Status" column is currently populated with the value of the "Payment Appliance".

Note that I have changed this to be the value of the "Payment Status". Not sure if this is the correct thing to do but it makes a LOT more sense to me now that I've done that...

[joelc]

Can not reproduce 6 through 8:

In the VM:

• I rejected payment 314 for claim_number 936068
• In the DB, I fudged the "administrator" user to have the same app_user.username as the payment.approval_user ("achavez") -- and I changed it in spngeo.xml also
• I logged in as this user and saw the approval pending
• I approved it
• I noted in the DB that the payment had transitioned to status 11 ("Annuity - Pending")

I am, however, going to supply the change I mentioned in my previous comment as I believe that corrects an error.

[pizza-and-dog]

Confirmed, sounds good.

[joelc]

Rashid, note that I have not tested the process that occurs during points (7) and (8) -- I don't know how to trigger this. Let me know if I should test this scenario please and, if possible, any indicators on how/what/where I get the job to run!

Thanks

[pizza-and-dog]

Please check the DB for number 7 & 8. For 7, it should be in the batch process, and for 8, you'll need to check the status within Payment History, and it should appear as “Reversal-Posted Complete.”

[joelc]

"Batch process"... That's where I'm stuck. I'll take a look in the code now.

On Wed, Jul 23, 2014 at 10:23 AM, Rashid Sial notifications@github.com wrote:

Please check the DB for number 7 & 8. For 7, it should be in the batch process, and for 8, you'll need to check the status within Payment History, and it should appear as “Reversal-Posted Complete.”

— Reply to this email directly or view it on GitHub https://github.com/nasa/SCRD/issues/47#issuecomment-49906367.

[pizza-and-dog]

Checkout this too: https://www.dropbox.com/s/0riubzg1dp4l36j/1_OPM_App_And_Role_Requirements_091113.doc

[joelc]

OK there are a couple of issues here. I did not catch this before because it was pure coincidence the data I was playing with aligned with the requirements already. Trying this process on a new entity revealed the issues.

The CURRENT state of the system dictates that when any Payment is approved it transitions into status 29 which is "Suspended". This is configurable in build.properties and 29 is the default value in the template right now.

So:

1) If I am approving a Payment with status "Reversed - Pending Approval", what do I need to make happen? Assume I transition into "Reversed - Pending". Correct?

2) When the batch job runs is should transition, however: there is no "Reversal-Posted Complete" or anything similar in the table on page 88 of this document. Please clarify!

3) The fact that other Payments are dropping into state 29 seems to be a bug but also and, if it is one, will need raising separately.

[pizza-and-dog]

Ok, here's how to address it:

1. Confirmed with some slight status wording changes. So once you set a payment to ”Reversal- Pending Approval”, and then once the batch process has ran (it runs every night), after it has run, it should change to “Reversal-Posted Complete”
2. Please add “Reversal-Posted Complete” to the DB.
3. Ok, if you can apply this fix to the other payments, that would be awesome. No worries if you feel it's out of scope.

[joelc]

3) Yup I'm happy to look at this was just concerned about... Mixing concerns. Do you want to raise another issue and label it as Part 2 or shall we track here? I am cool either way. No point in doing it half way

I will transition to "Posted - Pending" when a non-reversed Payment is approved.

[pizza-and-dog]

Thanks, let's track it here.

[joelc]

Actually this is more tricky than I thought - sorry.

Right now in the DB there are statuses such as "Adjustment - Pending Approval", "Adjustment - Pending", "Annuity - Pending Approval", "Annuity - Pending".

Can you confirm that when ANY of these "Pending Approval" Payments are actually approved, that they should transition to the corresponding "Pending" statuses?

So:

1) I approve an "Adjustment - Pending Approval". The Payment transitions to "Adjustment - Pending". Is this correct?

2) I think I also need to add a "Disapproved" PaymentStatus. At the moment the Payment has an ApprovalStatus that can be APPROVED, DISAPPROVED, PENDING. But then there are the more granular line items in the payment_status table - I think I need to add a "Disapproved" row there. I will pre-emptively do this in case it's the right thing to do. If not, please tell me.

[joelc]

Hold up. I think there's a more fundamental flaw. I'll send you a communication separately and we can loop back in on Github.

[pizza-and-dog]

Thanks, will respond to your email once I get it.

[joelc]

After discussion with Rashid by email:

1) When a payment is approved its payment_status will transition from "XYZ - Pending Approval" to "XYZ - Pending"

2) When a REVERSED payment is posted, its payment_status should transition from "Reversal - Pending" to "Reversal - Posted Complete"

3) When a NON REVERSED payment is posted, its payment_status should transition from "XYZ - Pending" to "Posted Complete".

Rashid - please confirm here!

[pizza-and-dog]

Confirmed!

[joelc]

Unfortunately this opens up a whole can of worms that is way out of scope - I am going to stick to the original request. My apologies...!

[pizza-and-dog]

Not a problem, let's just address the in-scope items and that'll be good enough.

[joelc]

Here you go - hopefully this hits the mark:

https://www.dropbox.com/s/tguyqfyyts8rfxm/issue-47-work.mp4

[pizza-and-dog]

That looks perfect, thank you!