Service History - Calc As Of Date Defaults to Current Date

[dcieslicki]

1. Go to View Account > Service History
2. Enter Service History info.
3. Select Run Calculation button.
4. Select Save Calculation button.
5. Select Trigger Bill button
6. Go to another account or exist the system.
7. Go back to the account.
8. ERROR: The "Calc as of" date is not the same date that was entered and previously saved.

[joelc]

It appears that the "calculate as of date" in the UI corresponds to the wire field interestedCalculatedToDate

There is no corresponding column in the DB calculation_version (which appears to aggregate calculations) table, nor in the entity beans that map to the table. It's also not sent on the wire in the save.

This fix appears to be a pretty heavy lift since there are AJAX, Java (EJB), DB and UX considerations (i.e .the "Save Calculation" button needs disabling / hiding if the calculation is run, the "Calculate as of date" is changed to something else, and the Save button is hit -- the wrong date will be persisted).

Please advise if you wish to keep this in the challenge and/or consider extending the deadline and prize!

[pizza-and-dog]

We'll keep it in the challenge. I'll give the challenge a nice boost in terms of prizes (see forum post).

[joelc]

Walkthru vid: https://www.dropbox.com/s/hmg841jdsqg1e3c/issue-66-walkthru.mp4

[psisrael]

This video does not effectively demonstrate the issue or the fix. First of all, please use an account and data that makes sense. This video used a calculation date prior to the date of the service performed (let alone the refund). We need to verify that the interest calculation corresponds to date the calculation was performed and saved.

Also note; the totals after the calculation results do not add (or subtract) correctly

[pizza-and-dog]

@psisrael - this ticket is specifically for the "Calc as of date", we cannot ask for other items to be added to it as it wasn't included in the scope of the contest, sorry for any confusion. Please contact me via email if you have any questions.

@joelc, please re-do the video, if possible.

[psisrael]

I did not add any other items, so the issue of scope is not on the table. I only gave more context as to why this is an issue, and why the demo did not demonstrate this functionality effectively.

[psisrael]

I did not add any other items, so the issue of scope is not on the table. I only gave more context as to why this is an issue, and why the demo did not demonstrate this functionality effectively.

From: Rashid Sial [mailto:notifications@github.com] Sent: Thursday, July 24, 2014 10:42 AM To: nasa/SCRD Cc: Israel, Pamela S Subject: Re: [SCRD] Service History - Calc As Of Date Defaults to Current Date (#66)

@psisraelhttps://github.com/psisrael - this ticket is specifically for the "Calc as of date", we cannot ask for other items to be added to it as it wasn't included in the scope of the contest, sorry for any confusion. Please contact me via email if you have any questions.

@joelchttps://github.com/joelc, please re-do the video, if possible.

— Reply to this email directly or view it on GitHubhttps://github.com/nasa/SCRD/issues/66#issuecomment-50027203.

[pizza-and-dog]

Ok cool, not a problem! It's just that this ticket doesn't cover "the totals after the calculation results do not add (or subtract) correctly", which is handled in another ticket, I believe. If they're not, we can't introduce them at this point since the scope is fixed for contests.

[joelc]

No probs how's this: https://www.dropbox.com/s/1kprysai2di3dtc/issue-66-walkthru-2.mp4