NASA-Tournament-Lab / CoECI-OPM-Service-Credit-Redeposit-Deposit-Application

This repository houses code for the United States Office of Personnel Management Service Credit Re-deposit/Deposit (SCRD) Application.
Apache License 2.0
6 stars 9 forks source link

Service History - Redeposit & Deposit Boxes #70

Open dcieslicki opened 10 years ago

dcieslicki commented 10 years ago
  1. This is regarding scenario 8 (Ret Scenario - Mixed CSRS & FERS new categories needed.pdf, which can be accessed here: https://drive.google.com/file/d/0B4MmZDLfhZYfalB1TUZRY3NCU0k/edit?usp=sharing).
  2. Run the scenario, which includes both CSRS & FERS.
  3. Scroll to the Redeposit and Deposit boxes.
  4. The calculations were fine but the system did not post the CSRS redeposit in any of the billing categories. The FERS deposit and redeposit were posted accurately and the totals included the CSRS redeposit. However, the system must post all the amounts in the appropriate billing categories in order for the customer to determine what he or she wants to pay and in order for the payments to be posted and recalculated correctly.
joelc commented 10 years ago

After the changes I made to #53, the CSRS Redeposit is displaying in "CSRS Post82/Pre 91 Redeposit".

I don't actually know where the source requirements/materials reside so I can validate that this is correct but I am going to infer that "if the end date is between 10/1/82 and 3/1/91", as this does, then it should appear there. But I don't like second guessing so holler if I'm wrong.

pizza-and-dog commented 10 years ago

The two requirements docs are:

  1. https://github.com/nasa/SCRD/blob/master/Documents/All_Project_Output/Track_2/Design_%26_Requirements/1_OPM_App_And_Role_Requirements_091113.doc
  2. https://github.com/nasa/SCRD/blob/master/Documents/All_Project_Output/Track_2/Design_%26_Requirements/2_OPM_Reporting_Requirements_V3.doc

But the best resource for the scenarios is: https://www.dropbox.com/s/2slv2hpsez3a52g/TopCoder-Charts%20and%20business%20rules%20for%20computing%20time%20and%20amounts.docx

In the doc mentioned above, are all of the date rules.

pizza-and-dog commented 10 years ago

@dcieslicki, do you mind defining the dates for the categories? I tried to find the dates but couldn't find them, so if you can confirm that would be helpful too.

joelc commented 10 years ago

Confirming this is working as it should - see attached. This is another "as of date should be the same as the calculation explanation". When set to 8/9/2013 the numbers match!

issue-70

pizza-and-dog commented 10 years ago

Please try entering a scenario for a brand new account vs. using the default account that has the saved scenarios. Need to make sure this works for established accounts, new accounts, or in the Create New Account wizard. If it does work, then we're all set! A good scenario to use is: https://drive.google.com/file/d/0B4MmZDLfhZYfSHpLYlZXQzA2MUk/edit?usp=sharing

joelc commented 10 years ago

All good with a new account!

issue-70-new-scenario

pizza-and-dog commented 10 years ago

@dcieslicki, do you mind confirming if this is accurate?

joelc commented 10 years ago

The Post Deposit Interest in the screen is $168.02 vs. $168.04 on the printed materials - but am letting a couple cents slide per your other comments...

pizza-and-dog commented 10 years ago

Confirmed, a few cents off is okay.

dcieslicki commented 10 years ago

CSRS Post 3/91 Redeposit: service period that was refunded ended on or after March 1, 1991. CSRS Post 82/Pre 91 Redeposit: service period that was refunded ended on or before February 28, 1991 but after October 1, 1982.

dcieslicki commented 10 years ago

You did not show the billing area for the scenario we cited - please show us the billing area for the CSRS redeposit/FERS deposit/FERS redeposit. The billing area you showed for the second scenario only contains a CSRS pre/post deposit, which is working correctly.

joelc commented 10 years ago

Bottom half of display showing the billing area for Rashid's scenario

issue-70-new-scenario

joelc commented 10 years ago

Bottom half of the screen for original scenario - please confirm this looks good:

screen shot 2014-07-23 at 8 26 51 am

psisrael commented 10 years ago

Please provide copy of billing statement that corresponds to these totals, plus screenshots of this scenario using Create New Account.

joelc commented 10 years ago

Screenies here: https://www.dropbox.com/sh/g6ir3bavhitiyk1/AACJU10nxQeTW4k57R7l9ybha